From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: bug#38421: Status: 27.0.50; Gnus fontifies patch attachments when gnus-visual is nil Date: Sun, 19 Jul 2020 17:20:08 +0200 Message-ID: <87d04rpm53.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25665"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: bug#38421 <38421@debbugs.gnu.org> To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 19 17:20:55 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxB7W-0006Y8-Io for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Jul 2020 17:20:54 +0200 Original-Received: from localhost ([::1]:35596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxB7V-00045B-Kb for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Jul 2020 11:20:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxB6x-0003U5-9V for emacs-devel@gnu.org; Sun, 19 Jul 2020 11:20:19 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:52578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxB6v-00020r-KY for emacs-devel@gnu.org; Sun, 19 Jul 2020 11:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vwvb9HfzbqBm/g0gLSvc26qH827TJzwISbxti5z/sJk=; b=a7o9a0I7ABd7qZE2aRx9RoKa1Z GnBLpGodEAaiiyJGUYnDcdk5LRL/5w7mocyUitktouq/QHLSeT4wlkGCVy9SURIRfDPjzUhn9mQan HU/3skxa2nbgVYRzCR0Q3IQ0y4PtHocFdi+8eygsiNUNzhcVZRVTVJMmYjawSEvy82VQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxB6n-0007FE-W4; Sun, 19 Jul 2020 17:20:15 +0200 In-Reply-To: (Filipp Gunbin's message of "Tue, 17 Dec 2019 15:55:52 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253104 Archived-At: Filipp Gunbin writes: > Could someone please review the patch? (bug#38421) > > It's simple, but I'm not sure about using gnus-visual-p in mm-* files. I don't think we can use that function there, because these are general utility functions (used by mh-e, for instance). As the comment in mm-view.el says: ;; Shouldn't these functions check whether the user even wants to use ;; font-lock? They should, indeed. But I'm not quite sure what the correct approach for the application (that is Gnus) to inhibit these functions... What functions to use is decided by mm-inline-media-tests, and there's no way to use one version if we want highlights and another if we don't... Anybody got any ideas here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no