From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: feature/icomplete-vertical Date: Mon, 05 Oct 2020 10:13:30 +0100 Message-ID: <87d01xghmt.fsf@gmail.com> References: <20200912133311.6ujtgczj6wyclufy@Ergus> <20200920130435.heye7bk73pm252km@Ergus> <83sgbczj0i.fsf@gnu.org> <83lfh4zfml.fsf@gnu.org> <838sd4z6lz.fsf@gnu.org> <20201001164804.mqqyxtet4ttweuyv@Ergus> <83blhhdy3w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16670"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: ghe@sdf.org, spacibba@aol.com, juri@linkov.net, casouri@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 05 11:14:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPMZV-0004El-Lj for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 11:14:17 +0200 Original-Received: from localhost ([::1]:56230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPMZU-00043s-LD for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Oct 2020 05:14:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPMYp-0003dt-VO for emacs-devel@gnu.org; Mon, 05 Oct 2020 05:13:35 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:38426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPMYo-0005iV-0e; Mon, 05 Oct 2020 05:13:35 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id n18so835081wrs.5; Mon, 05 Oct 2020 02:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=klBcQd8gI8pj1BISCKON+aUuoxHdNe24IK6cf+XOLOg=; b=TwU6lgRmwnSl2g1QgmSU1T14AlhuMYfRQIBSFkApai75Lx+dhas2dEZoyztJ+b1YRm QFnwVqiaDhWt9LNTP6aWEGu4eut/7fPZJTlKtVc4yYERVFmUSjdT6QyVK7C33EptLFVT 3/XvDaV5si7QiY4pHbc4SMe1Ubh06SYOdOEptX29O6li9CPxW8H23nBwnVTAEnCCp40L SFXSsEvRihdYM2Xj5PZZcudj8aws+w2ZFTEKMlvXVDxidyk/+JhT7B/x6OIsAW6jnq4u B1sQjzObhsaUfzlKn1H6JwZI6KAkpyS9GfuHBLcFxu+FVU/ckuo+7AKoyUY4xxAjlX9F tmmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=klBcQd8gI8pj1BISCKON+aUuoxHdNe24IK6cf+XOLOg=; b=aNe8ybCzYV/dsEps7D7aSEF/t0KGhMk4a0RY8qF+4lqVFO7VhseSXzkctLfCF6yNQR 8JinYyMr1Ax42yOJp0r9sFQfroLlBYIiOHE17cJeDB+mCL5Rpe0PEEeojkbKMWnzGyAu /1T5ImiTyax/OfKF4rISKIo+rqdcYGN2wYMtBeMjRysywv9madeun+mzEcRz0qLEE+Sf qfWNO/SqICm67uH9jKpFoa1KT15OS1ZfjF9xcLqT5hZlfNOzFMKGpcpOM8WsQqqgolJQ Mv4W9dD1vMDoGTudplLnJhyZVyyTmexv2INaXlstMAEVxFAodZ4Dcl3GDbmZvWDK2yFu V3bw== X-Gm-Message-State: AOAM533vSbNyJ/7cIw7Bb2YBJCQhKCrHmQTeJAuKybLMnK61KWmgKvkU auwAiJGX9pO+/wps+J7zpxw= X-Google-Smtp-Source: ABdhPJz8iDG211n/+0vQI75BtrNn0+PM7D9BHo4UYvQKQszAIn5qgcJA5PBS0f0iraetb4a0kMaN0w== X-Received: by 2002:a5d:4c4c:: with SMTP id n12mr16245258wrt.162.1601889212005; Mon, 05 Oct 2020 02:13:32 -0700 (PDT) Original-Received: from krug ([89.180.147.115]) by smtp.gmail.com with ESMTPSA id y6sm12180015wrt.80.2020.10.05.02.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 02:13:31 -0700 (PDT) In-Reply-To: <83blhhdy3w.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Oct 2020 08:45:55 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x429.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257091 Archived-At: Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Date: Mon, 5 Oct 2020 00:47:39 +0100 >> Cc: Eli Zaretskii , Gregory Heytings , Yuan F= u ,=20 >> emacs-devel , Juri Linkov >>=20 >> (defun icomplete-vertical-adjust-minibuffer-height (completions) >> (let* ((comp completions) >> (complen (length (split-string comp "\n")))) >> (if (> complen 1) (enlarge-window (- icomplete-prospects-height (1-= (window-height))))) >> comp)) >> (advice-add 'icomplete-completions :filter-return #'icomplete-vertical-a= djust-minibuffer-height) > > What happens with your solution if you need to enlarge the mini-window > to a height that is greater than the frame's height? I don't know. Wouldn't I need an extremely stubby frame to achieve that? Anyway, that's not even my code. As I explained to Ergus, just wanted to underline that a solution without new user interfaces can be a starting point with bugs that are fixed as bugs. I doubt that systematically fixing these bugs would necessarily leads us to a solution with N new defcustoms and a new minor mode. Jo=C3=A3o