From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Tue, 08 Dec 2020 21:32:55 +0100 Message-ID: <87czzk9gy0.fsf@gnus.org> References: <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <837dpt8lk5.fsf@gnu.org> <87pn3kjssr.fsf@gnus.org> <83im9c70vu.fsf@gnu.org> <87im9cfeej.fsf@gnus.org> <837dps6xyv.fsf@gnu.org> <87czzkdx57.fsf@gnus.org> <83v9dc5he3.fsf@gnu.org> <87r1o0chk9.fsf@gnus.org> <83tusw5g5o.fsf@gnu.org> <87360gaz7o.fsf@gnus.org> <87y2i89jjk.fsf@gnus.org> <83lfe859ro.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23599"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: ghe@sdf.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 08 22:33:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmkc7-00060V-RT for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 22:33:39 +0100 Original-Received: from localhost ([::1]:32872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmkc6-0000Yc-Ry for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Dec 2020 16:33:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmjfe-0000GY-9t for emacs-devel@gnu.org; Tue, 08 Dec 2020 15:33:14 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:45940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmjfc-00071d-Gk; Tue, 08 Dec 2020 15:33:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tvFMd+SXQZODj7OE9dvzhrjUCmk5NFhnojiSZ4xMfss=; b=ndtfBETyQZDX6MSRAT1KG1CBTl tfYpxOigeQReutDwx27Jq4Sc74Qxxv3B3xzbVUFtmiOSN30OLiqW7sMQv2rXeZKqVNY6xB/HxwKJ5 kOIfz0K3D4mYDvjh1bhG562ml2XipfICQrL+bK/5iO9U8Iqj3KkXv2rcraqoVLcX4WlE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmjfN-0007cC-CE; Tue, 08 Dec 2020 21:32:59 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEWRjpKeoKp1boRt cHHOusODb3JqaFmQjG57f31FQUAmJCyBfFm/0lb////0NsUKAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QMCBQdOI0E6fQAAAD9SURBVDjL7Y+xSwMxGMXvcOjaQP+AkhDBTe7DA3G6GuwqPeLSzYNP7joW Wrt19C9QLh2FwGW3S/YO1j/KdBATMXuHvvH93vs+XpKcdNKRKh1GQP8yAkb3kUu3EZ+cRUD/PFJ4 xn8BIZNXuXT6EyfFONNTa7EK8wMh7kAjYpWHYJ2KlXIAMhZeGohipd4pUJ6FthDjnXnkVPLyF7yk lDBx89Vk0slrJGVjdLHZKQcoDX48KF2+fRoqKQPwgZyqerPv+ITl6M/vLbA27b67Ym7IkweWCHnT 1i11edx6hTkwuNBtl+PMWusVgEsAY/TB/5DJz/vetgKna4M4Owz5BmTMSutjqjhOAAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIwLTEyLTA4VDIwOjI5OjU2KzAwOjAwAHup8gAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMC0xMi0wOFQyMDoyOTo1NiswMDowMHEmEU4AAAAASUVORK5CYII= X-Now-Playing: Oneohtrix Point Never's _Magic Oneohtrix Point Never_: "Tales From The Trash Stratum" In-Reply-To: <83lfe859ro.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Dec 2020 22:21:31 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260582 Archived-At: Eli Zaretskii writes: >> + case Lisp_String: >> + val = (EMACS_UINT) SSDATA (obj); > > Why use the pointer? Lisp strings can be relocated, and there could > be another string with the same contents. Why not support those? Yes, that's not a good ID for the string. What's the proper way to get the identity of the string object? >> - while ((img = search_image_cache (f, spec, sxhash (spec), 0, 0, true))) >> + while ((img = search_image_cache (f, spec, img_hash (spec), 0, 0, true))) > > Any reason you call img_hash in a loop with the same argument? It's not me; it's search and replace. And, no, there's no reason why the sxhash in in that loop; it should be fixed regardless. > Last, but not least, a question: what kind of savings will this > produce, and why? It depends on many different things, but between 0% and 20% in my test cases. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no