From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Adam Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] tab-line-alternate-colors Date: Tue, 15 Dec 2020 20:58:35 -0600 Message-ID: <87czzaxxr8.fsf@alphapapa.net> References: <87360autpy.fsf@alphapapa.net> <87mtyiqfzv.fsf@mail.linkov.net> <87tusqt3yr.fsf@alphapapa.net> <834kkpenox.fsf@gnu.org> <87lfe1t9l3.fsf@alphapapa.net> <83eejscsg0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29021"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 16 03:59:59 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpN2l-0007Rg-PE for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Dec 2020 03:59:59 +0100 Original-Received: from localhost ([::1]:34890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpN2k-0001FC-Rw for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Dec 2020 21:59:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpN1Y-0000kd-Vi for emacs-devel@gnu.org; Tue, 15 Dec 2020 21:58:44 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:36512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpN1W-0007Jm-EL for emacs-devel@gnu.org; Tue, 15 Dec 2020 21:58:44 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kpN1U-0005xF-4R for emacs-devel@gnu.org; Wed, 16 Dec 2020 03:58:40 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260943 Archived-At: Eli Zaretskii writes: >> AFAIK there's no way to inherit only a certain attribute of a face, >> other than using an anonymous face made at runtime. If there were, it >> would be simple to just inherit the mode-line face's background color. > > I'm not sure I understand why would want to inherit just the > background color. What's wrong with inheriting all the rest? I would guess that the mode-line face could have other attributes that we wouldn't want to interfere with the tab-line faces, e.g. size or family. The only reason I would want to inherit from mode-line is to get the background color. Since this doesn't seem advisable, I've changed the definition of the tab-line-tab-special face to define the background color explicitly, using one which is slightly darker than the tab-line face's default. >> >> +(defface tab-line-tab-special '((t (:slant italic))) >> > >> > What will this do on terminals that don''t support italic? >> >> Nothing, I suppose. :) I don't often use Emacs in a terminal, so I'm >> not as familiar with that issue. >> >> I'll be glad to follow whatever guidance you may provide here. Thanks. > > I guess if italics isn't supported, you could use bold or some > foreground color instead? Sure. I've changed the face definition to only use italic on terminals that support it, and to default to bold otherwise. These changes will be in the next patch version. Thanks.