From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Poll: Change xref-show-definitions-function's default? Date: Wed, 06 Jan 2021 20:30:56 +0200 Organization: LINKOV.NET Message-ID: <87czyh52rj.fsf@mail.linkov.net> References: <9af40a30-8964-3142-aadf-6592605720ec@yandex.ru> <871rf0ob2c.fsf@mail.linkov.net> <7b108ef2-7798-19b9-f37d-680bdcb23745@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35975"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 06 19:41:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxDkK-00099u-0b for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 19:41:24 +0100 Original-Received: from localhost ([::1]:59590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxDkJ-000885-2G for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 13:41:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxDik-0007JJ-Q3 for emacs-devel@gnu.org; Wed, 06 Jan 2021 13:39:47 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxDii-0002WI-Gj for emacs-devel@gnu.org; Wed, 06 Jan 2021 13:39:46 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1DEB4C0008; Wed, 6 Jan 2021 18:39:32 +0000 (UTC) In-Reply-To: <7b108ef2-7798-19b9-f37d-680bdcb23745@yandex.ru> (Dmitry Gutov's message of "Mon, 4 Jan 2021 20:41:52 +0200") Received-SPF: pass client-ip=217.70.183.198; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262624 Archived-At: >> As part of this poll we could also decide what to do with the TAB keybinding >> because especially after changing the value of 'xref-show-definitions-function' >> to 'xref-show-definitions-completing-read' and using the *xref* buffer >> exclusively for the grep-like output, it makes more sense for >> TAB to behave as in grep-mode. > > No need to poll about that, I think. > > As long as we change the default to one of the current two alternatives, > TAB won't play any role in either (the -at-bottom function sets up RET to > call the same command). I'm afraid the default of xref-show-definitions-function can't be changed to xref-show-definitions-completing-read because as this poll indicates it works satisfactorily only in combination with icomplete-mode and also non-nil icomplete-show-matches-on-no-input. > Then we can safely remove/change the TAB binding in xref--xref-buffer-mode, > or alternatively, create a new major mode that is slightly more Grep-like, > and use it in the default xref-show-xrefs-function. Maybe a new submode could help to resolve this discrepancy.