From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check Date: Mon, 11 Jan 2021 21:56:57 +0100 Message-ID: <87czyb2nvq.fsf@gmail.com> References: <83sg7mggls.fsf@gnu.org> <83czymc8nq.fsf@gnu.org> <74b7a0a9-0eb3-7944-19d2-f72424ee72d7@dasyatidae.com> <83eeirfqbo.fsf@gnu.org> <87o8hvscfi.fsf@gmail.com> <8335z7fmnz.fsf@gnu.org> <87ft374axc.fsf@gmail.com> <83wnwjdwww.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6666"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rtt@dasyatidae.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 11 21:57:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kz4GA-0001e7-4y for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jan 2021 21:57:54 +0100 Original-Received: from localhost ([::1]:56768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz4G9-0007Z7-7V for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Jan 2021 15:57:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz4FK-00077P-Ke for emacs-devel@gnu.org; Mon, 11 Jan 2021 15:57:02 -0500 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:46927) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz4FI-0005Hc-Ss; Mon, 11 Jan 2021 15:57:02 -0500 Original-Received: by mail-wr1-x430.google.com with SMTP id d13so141245wrc.13; Mon, 11 Jan 2021 12:57:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=05Vt188KwpKfWTLGfCWsDLiKN9aQDR3rFXca5xMNggU=; b=XMC6TLDNzLUCbLBmXNO5ZCVgx2h4KkP/T40SptMbDkrbpp99N45XOjm7UJFqZQ3yP0 t9Y8X8hR9qSNnM+O1mk65df4WrTU6Esl4qduGFxy6K8oEB0h2B+nbfele37XCwE9zUsq KedbcOk2I6tjodIv/UZOJ9EdvRH7vvXab+tumigkbwgk5W0S1zTTj57D4tUAC+Kx+W5k SC+OkeF0XaCdQHNj8O0ZZbxR5zalFBX79OOyYA0V16hSZ+MFTqijCQ3Bp0F/CkjYZ1A/ 8uM0u8Xd+uejor0NdV9wcgmt3kuoEcpDb0bpm3tTxk2S+pISewulytum3TxdIzG4+mRo Q+ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=05Vt188KwpKfWTLGfCWsDLiKN9aQDR3rFXca5xMNggU=; b=TEc4+h5ikcdhcH4lV6WGDL4a6a++7CmftDD1xz+rPO3ZY78I+NNcc5fGqPojmD7Ott NBsVJHhVbyBub+kDV+S265qrHGJueLekwmmgTuhiQJtYPixLntAAY/5zdZq7PE2g4ORf s6Dt/+ThqnwA5BsURnnMwRnFLtcc6yQX7scheZy2/i0pgIST6QMPCX9/Tp3NgjxUa+BO FevaKNP1peuZ1CDsTfG6uQx+o3qItOmnYGONooKoo7lW/DFRNBpaJB0FNG4yZw6feJ2j yfiEfr63R55HThdSnmmb6KRaxs+rhCfv8N9qU1AJjHBOJFQ3QhvNOiwGMg0tNbUTLp2B MdMA== X-Gm-Message-State: AOAM533PN5TGJVvI19nbJfRt85v4ea7NL7XCPwkTdEsQIPwXcbI5puEg /xLKezY1FxweCitjrCe2tbg3K9w9QvResA== X-Google-Smtp-Source: ABdhPJyQiz1Zi2WNJPS6s/9D1Rvlti8QvasdLQwQvd/GatYWhSWnhvshKmfmN4rJJoI4r4EQD1hUNw== X-Received: by 2002:a5d:4d8b:: with SMTP id b11mr880894wru.215.1610398618749; Mon, 11 Jan 2021 12:56:58 -0800 (PST) Original-Received: from rltb ([2a01:e34:ecfc:a861:69b6:6aaf:dbd3:8964]) by smtp.gmail.com with ESMTPSA id n16sm1146282wrj.26.2021.01.11.12.56.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 12:56:58 -0800 (PST) In-Reply-To: <83wnwjdwww.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Jan 2021 22:46:23 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=rpluim@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262936 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: Eli Zaretskii , emacs-devel@gnu.org >> Date: Mon, 11 Jan 2021 18:53:51 +0100 >>=20 >> (require 'dns) >> (skip-unless (dns-query "google.com" 'AAAA)) >>=20 >> and then do the network-lookup-address-info tests (although on Windows >> this depends on DNS over TCP working, and either /etc/resolv.conf or a >> working nslookup). Eli? > > Tell me what to try, and I will show the results. TIA. I=CA=BCve lost track of which tests were failing, but something like following. And if the 'dns-query' calls succeed but the network-lookup-address-info ones fail then we have a really messed up situation. diff --git a/test/src/process-tests.el b/test/src/process-tests.el index 921bcd5f85..172294b0ed 100644 --- a/test/src/process-tests.el +++ b/test/src/process-tests.el @@ -356,7 +356,9 @@ lookup-family-specification (with-timeout (60 (ert-fail "Test timed out")) (should-error (network-lookup-address-info "google.com" 'both)) (should (network-lookup-address-info "google.com" 'ipv4)) - (when (featurep 'make-network-process '(:family ipv6)) + (when (and (featurep 'make-network-process '(:family ipv6)) + (require 'dns) + (dns-query "google.com" 'AAAA)) (should (network-lookup-address-info "google.com" 'ipv6))))) =20 (ert-deftest lookup-unicode-domains () @@ -380,7 +382,9 @@ lookup-google (addresses-v4 (network-lookup-address-info "google.com" 'ipv4))) (should addresses-both) (should addresses-v4)) - (when (featurep 'make-network-process '(:family ipv6)) + (when (and (featurep 'make-network-process '(:family ipv6)) + (require 'dns) + (dns-query "google.com" 'AAAA)) (should (network-lookup-address-info "google.com" 'ipv6))))) =20 (ert-deftest non-existent-lookup-failure ()