From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes Date: Wed, 17 Feb 2021 21:05:57 +0100 Message-ID: <87czwy1mu2.fsf@gnus.org> References: <20210213141225.11309.86562@vcs0.savannah.gnu.org> <20210213141226.EEDFE20999@vcs0.savannah.gnu.org> <47209379-76df-4c97-e5ff-b3b04da0db1d@yandex.ru> <87zh07of0e.fsf@gnus.org> <0605ed62-a785-d190-caf2-2232e1db3b0f@yandex.ru> <87mtw6d480.fsf@gnus.org> <87eehid3k2.fsf@gnus.org> <87r1liblzb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2190"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 17 21:08:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCT7g-0000QC-Ql for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 21:08:32 +0100 Original-Received: from localhost ([::1]:49952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCT7f-0004Cy-OI for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Feb 2021 15:08:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCT5R-0001ru-2N for emacs-devel@gnu.org; Wed, 17 Feb 2021 15:06:13 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:57644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCT5K-0002Yo-Oz for emacs-devel@gnu.org; Wed, 17 Feb 2021 15:06:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GDgOebdSxcVjH+FGJE1NY0DlLkFgy/1mFGixFowVWQo=; b=EqPlMuZtZko9Y6E1LWEvVdK/oD 6ISodO+mBXZCx6+BZ6clRxP4xpRmMAaaRvNtICkxHNxmTd+VywadSxYoVq+Gr0GoopmbWTrZMceyd +MKudHLoPjmCU08fTGg1f4DUQ7TGJTQek4YHhliBoWSqekX+90Lxr4aPgLHUIXztsQeU=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCT5D-0003q9-0f; Wed, 17 Feb 2021 21:06:04 +0100 X-Now-Playing: Deutsch Nepal's _Mort Aux Vaches_: "Father, 29 Needles, Horses Give Birth To Fires, October Lund-Home" In-Reply-To: (Stefan Kangas's message of "Sun, 14 Feb 2021 14:25:42 -0600") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265070 Archived-At: Stefan Kangas writes: > Please find attached a patch. Hm... trying this out now, I don't think the compat macro solution actually works. That is, it works fine when byte-compiled, but not in non-compiled code. The reason for this is that `interactive-form' just does a `Fassq' on the Lisp form and looks for the Qinteractive symbol. Which is won't find if the symbol in `future-interactive'. So I'm not sure a macro compat solution here can work. I should have caught this earlier, since I've been looking at `interactive-form' quite a bit lately. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no