unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ulf Jasper <ulf.jasper@web.de>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master a283996: Add command for customizing current newsticker feed
Date: Tue, 23 Feb 2021 19:38:58 +0100	[thread overview]
Message-ID: <87czwqhbnh.fsf@panama> (raw)
In-Reply-To: 87blcasoib.fsf@tcd.ie

Am 23.02.2021 um 17:05 (+0000) schrieb Basil L. Contovounesios:
> This call to (append (..) nil t feed-name) will signal an error.

This is fixed now.

>> +  (customize-variable 'newsticker-url-list)
>> +  (delete-other-windows)
>
> Doesn't this interfere with the user's display-buffer-alist
> customisations?  customize-variable uses pop-to-buffer, so in
> theory no further window adjustment should be necessary.

Removed call to 'delete-other-windows'.

>> +  (when (re-search-forward (concat "Label: " feed-name) nil t)
>
> Should this be 'search-forward' instead?

Changed.

Thanks!
ulf




  reply	other threads:[~2021-02-23 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210223164040.7990.38864@vcs0.savannah.gnu.org>
     [not found] ` <20210223164041.9DA5D20536@vcs0.savannah.gnu.org>
2021-02-23 17:05   ` master a283996: Add command for customizing current newsticker feed Basil L. Contovounesios
2021-02-23 18:38     ` Ulf Jasper [this message]
2021-02-23 17:35 Eli Zaretskii
2021-02-23 18:38 ` Ulf Jasper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czwqhbnh.fsf@panama \
    --to=ulf.jasper@web.de \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).