From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Mon, 08 Mar 2021 11:17:55 +0200 Organization: LINKOV.NET Message-ID: <87czwageno.fsf@mail.linkov.net> References: <83y2fcrzkt.fsf@gnu.org> <831rd4romg.fsf@gnu.org> <83zgzsq7xn.fsf@gnu.org> <83v9afriqp.fsf@gnu.org> <83zgzjhvdn.fsf@gnu.org> <83a6rhxwah.fsf@gnu.org> <837dmlxspt.fsf@gnu.org> <834khpxr0s.fsf@gnu.org> <8335x8ybw9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22698"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , larsi@gnus.org, emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 08 10:51:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJCXu-0005hm-Cw for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Mar 2021 10:51:26 +0100 Original-Received: from localhost ([::1]:43454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJCXt-0001m1-Cp for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Mar 2021 04:51:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJCXL-0001G1-9f for emacs-devel@gnu.org; Mon, 08 Mar 2021 04:50:51 -0500 Original-Received: from relay13.mail.gandi.net ([217.70.178.233]:30323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJCXH-0004Qg-Gi; Mon, 08 Mar 2021 04:50:51 -0500 Original-Received: from mail.gandi.net (m91-129-108-46.cust.tele2.ee [91.129.108.46]) (Authenticated sender: juri@linkov.net) by relay13.mail.gandi.net (Postfix) with ESMTPSA id 1E21480019; Mon, 8 Mar 2021 09:50:41 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Sat, 6 Mar 2021 11:32:45 -0600") Received-SPF: pass client-ip=217.70.178.233; envelope-from=juri@linkov.net; helo=relay13.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266166 Archived-At: --=-=-= Content-Type: text/plain > +(defface help-key-binding > + '((((class color) (min-colors 88)) :foreground "ForestGreen") > + (((class color) (min-colors 16)) :foreground "green") > + (((class color) (min-colors 8)) :foreground "green") > + (((class color grayscale) (background light)) :foreground "grey15") > + (((class color grayscale) (background dark)) :foreground "grey85") > + (t :foreground "ForestGreen")) > + "Face for keybindings in *Help* buffers. I wonder why green? It looks quite weird. All the most popular markup renderers nowadays such as GitHub and GitLab display keybindings using light grey background like this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=help-key-binding-background-grey.patch diff --git a/lisp/faces.el b/lisp/faces.el index b2d47edca0..0f956b0cde 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -2816,11 +2816,11 @@ help-argument-name :group 'help) (defface help-key-binding - '((((class color) (min-colors 88) (background light)) :foreground "ForestGreen") - (((class color) (min-colors 88) (background dark)) :foreground "#44bc44") - (((class color grayscale) (background light)) :foreground "grey15") - (((class color grayscale) (background dark)) :foreground "grey85") - (t :foreground "ForestGreen")) + '((((class color) (min-colors 88) (background light)) :background "grey85") + (((class color) (min-colors 88) (background dark)) :background "grey25") + (((class color grayscale) (background light)) :background "grey85") + (((class color grayscale) (background dark)) :background "grey25") + (t :background "grey85")) "Face for keybindings in *Help* buffers. This face is added by `substitute-command-keys', which see. --=-=-= Content-Type: text/plain BTW, I noticed after typing 'C-u C-x =' that face information is duplicated: There are text properties here: face help-key-binding font-lock-face help-key-binding --=-=-=--