From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/files.el: Add `file-name-set-extension` Date: Wed, 26 May 2021 09:34:11 +0200 Message-ID: <87czteeyoc.fsf@igel.home> References: <6ff4b7d7-03ac-48d1-8d49-de66431d4e5b@www.fastmail.com> <87lf82y9pv.fsf@tcd.ie> <3780a7f9-19f4-4216-baa9-ce00b3dbace9@www.fastmail.com> <6ba4668c-9b39-40e0-a155-f7e583fd33b6@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33067"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: "Basil L. Contovounesios" , Stefan Monnier , emacs-devel@gnu.org To: "Colin Woodbury" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 26 09:35:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llo4S-0008Ka-53 for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 09:35:16 +0200 Original-Received: from localhost ([::1]:47054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llo4Q-0007r0-SY for ged-emacs-devel@m.gmane-mx.org; Wed, 26 May 2021 03:35:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llo3W-0007AV-D9 for emacs-devel@gnu.org; Wed, 26 May 2021 03:34:18 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:56750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llo3U-0000UF-2N for emacs-devel@gnu.org; Wed, 26 May 2021 03:34:17 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4FqjPc5Frfz1qt4c; Wed, 26 May 2021 09:34:12 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4FqjPc4ZgGz1qr3k; Wed, 26 May 2021 09:34:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id sdbURbpZJB2Y; Wed, 26 May 2021 09:34:11 +0200 (CEST) X-Auth-Info: 8+ZPjd2IpRlMpOW4k7vHzOdiowgY59XhXyGIiCBWKAdnLNd/J8X3KGigaoPrcfJE Original-Received: from igel.home (ppp-46-244-176-177.dynamic.mnet-online.de [46.244.176.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 26 May 2021 09:34:11 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 4F5BB2C3348; Wed, 26 May 2021 09:34:11 +0200 (CEST) X-Yow: Is this ANYWHERE, USA? In-Reply-To: <6ba4668c-9b39-40e0-a155-f7e583fd33b6@www.fastmail.com> (Colin Woodbury's message of "Tue, 25 May 2021 14:44:30 -0700") Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269908 Archived-At: On Mai 25 2021, Colin Woodbury wrote: > +Returns nil if either of the FILENAME or EXTENSION are nil before > +dot consolidation, or empty afterwards." > + (when (and filename extension) I still don't see any reason to allow nil. A file name is always a string. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."