From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 7b50ed5: Ask if dir and subdir dired buffers be killed when deleting dir Date: Sun, 13 Jun 2021 00:09:08 +0100 Message-ID: <87czsqwui3.fsf@tcd.ie> References: <20210604200934.4659.34841@vcs0.savannah.gnu.org> <20210604200935.87641209AA@vcs0.savannah.gnu.org> <878s3fuwsc.fsf@tcd.ie> <877diznsod.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5748"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 13 01:09:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lsClE-0001Jp-RJ for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Jun 2021 01:09:52 +0200 Original-Received: from localhost ([::1]:57226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsClD-0004Mp-RI for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Jun 2021 19:09:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsCkh-0003iS-5B for emacs-devel@gnu.org; Sat, 12 Jun 2021 19:09:19 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:56213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsCkd-0003ud-Tl for emacs-devel@gnu.org; Sat, 12 Jun 2021 19:09:18 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id g204so9939763wmf.5 for ; Sat, 12 Jun 2021 16:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=DsKcq0wucSUtN3Ejx8w6tZR6nTh5mp9YJtm7JKHIOQw=; b=YW0xuBm5+YDvAKlG1y9k7XLMgcVMZTpLDF4mh7xg14aSpT/t5sBtuJcTP1oB8gfUjy mXpaJTPYr0xiIANUze0E8OX0Z5RRjLtohVq5hyVTjhaSTdtOTjH1rfviCbQ0cpwLevbb 0AJ1BcKmbiXo8kDs1usL3Zxfj0wmDg1tTxshal7+sMYYuLD981/53jqicw/wL/0N5Jgq 8QD+M+uGmqwF7kTrgEHti4bVaUZDc8r2+KS9CMiO0jna3482yr86ETKVNbjNe91+CjHG i74LZCiAF2KaihT1DOcu2A/bMue4d0QBHoA1wI62bvx8WWpXT653g+8gCBsx0E91Tf16 zUBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=DsKcq0wucSUtN3Ejx8w6tZR6nTh5mp9YJtm7JKHIOQw=; b=XqFlz+Lk9KuUoJUcsYVDJZ1lnWoNJFiZ+ns6C3sx2ePy3EwTvnCH32bovrp/Ru17p6 Bw9goupql7FYl3sXEwf2w64cKUYcjpQnFb1WMlyRsHAfC2Cjda5hDV7+9TFtxkgTMMXC kmzcoAREZpDoRe/Erns1fZV4Em//AiigWCabc2S/0g0ozRjI/FLsi5bytGX5dVTz3J1n A8odmfSZIzwche01bhJCI3vu9gwux4xf0oJ6hrNvrElCz6+XzHNvSeN8HcG2ztle/oBi Xdf+qQW4KBkWpXt+PlY4vw2ZT8fmJ3hp7zvqB8Cld7Q0oMF2+WcTgLOPqdMuYcV0j9yL COZw== X-Gm-Message-State: AOAM531TR87042VtnfV6f6w9LH9kbOZFa5dh1CfdOe8cfzWXq1bWfWYC Kw5UtZr8BL/J4V2ihSN5ANYfYQ== X-Google-Smtp-Source: ABdhPJxoSEa8+9ohkVCOt4Sykqh2ubV2/S8SpE3Fpk+rVlNGhK7/AR3WHfVS+guxP3IhNZEMFnFxSg== X-Received: by 2002:a7b:c042:: with SMTP id u2mr9477600wmc.127.1623539351017; Sat, 12 Jun 2021 16:09:11 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id v132sm17344068wmb.14.2021.06.12.16.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jun 2021 16:09:10 -0700 (PDT) In-Reply-To: <877diznsod.fsf@gnu.org> (Tassilo Horn's message of "Sat, 12 Jun 2021 14:53:33 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=contovob@tcd.ie; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270781 Archived-At: Tassilo Horn writes: > "Basil L. Contovounesios" writes: > But sorry, I've read your mail on my phone without noticing the patch. > I've done basically the same right now before actually reading your mail > again in a proper MUA. Thanks, that's all that matters :). > I haven't done this: > > diff --git a/lisp/dired.el b/lisp/dired.el > index bb428e2198..8c7bff31cb 100644 > --- a/lisp/dired.el > +++ b/lisp/dired.el > @@ -2912,10 +2912,10 @@ dired-unadvertise > ;;; utility functions > > (defun dired-in-this-tree-p (file dir) > - ;;"Is FILE part of the directory tree starting at DIR?" > + "Return non-nil if FILE is part of the directory tree starting at DIR." > + (declare (obsolete file-in-directory-p "28.1")) > (let (case-fold-search) > (string-match-p (concat "^" (regexp-quote dir)) file))) > -(make-obsolete 'dired-in-this-tree-p 'file-in-directory-p "28.1") > (define-obsolete-function-alias 'dired-in-this-tree > 'dired-in-this-tree-p "27.1") > > Can you tell me the difference between this and `make-obsolete'? The only difference AFAIK is that the former is translated into the latter; see defun-declarations-alist, in particular byte-run--set-obsolete. You can verify this by invoking 'M-x pp-macroexpand-last-sexp' with point after the relevant defun. So it's just an aesthetic preference of mine for keeping function properties within the function's definition if possible, as it feels more atomic and declarative. > And will that also trigger a warning during byte-compilation of code > using the function or only when it is actually called? The same byte-compilation warnings should be omitted as with make-obsolete. > Feel free to do that change if you think it is better. Not a big deal; it was just an opportunistic change ;). Thanks, -- Basil