From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Definition reasoning of revert-buffer-function, should it be defvar-local? Date: Tue, 10 Aug 2021 16:34:26 +0200 Message-ID: <87czql8j2l.fsf@igel.home> References: <874kbxwgmu.fsf@posteo.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Daniel Nagy Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 10 16:35:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDSr0-0001Qn-Bd for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Aug 2021 16:35:42 +0200 Original-Received: from localhost ([::1]:47290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDSqz-0006RA-8N for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Aug 2021 10:35:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDSpv-0004sd-FS for emacs-devel@gnu.org; Tue, 10 Aug 2021 10:34:35 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:44375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDSps-0002gW-DF for emacs-devel@gnu.org; Tue, 10 Aug 2021 10:34:35 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Gkb7T2sGRz1qw98; Tue, 10 Aug 2021 16:34:29 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Gkb7T2Zqkz1qqyG; Tue, 10 Aug 2021 16:34:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id o6DpP0wK8bLz; Tue, 10 Aug 2021 16:34:28 +0200 (CEST) X-Auth-Info: /M/0wiMzgjq9L6lx2r3LuddLL0TE6kn8ynhdL52JAFNBg2cXhC79viu8cZlMVxpY Original-Received: from igel.home (ppp-46-244-191-35.dynamic.mnet-online.de [46.244.191.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 10 Aug 2021 16:34:28 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id E016E2C259F; Tue, 10 Aug 2021 16:34:26 +0200 (CEST) X-Yow: ...Get me a GIN and TONIC!!...make it HAIR TONIC!! In-Reply-To: <874kbxwgmu.fsf@posteo.de> (Daniel Nagy's message of "Tue, 10 Aug 2021 13:51:38 +0000") Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272278 Archived-At: On Aug 10 2021, Daniel Nagy wrote: > I want to understand the reasoning behind the definition and the intention of > the variable `revert-buffer-function`. > > In `files.el` I see the following definition: > >> (put 'revert-buffer-function 'permanent-local t) >> (defvar revert-buffer-function #'revert-buffer--default) > > The first line suggests to me, that the intention of the variable is that it is > supposed to be buffer-local, but `defvar-local` was not used. When these lines were written, defvar-local didn't exist. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."