From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: fido-vertical bindings Date: Tue, 17 Aug 2021 13:08:37 +0100 Message-ID: <87czqcw9x6.fsf@gmail.com> References: <20210817000745.cpnevwj7anmarue2.ref@Ergus> <20210817000745.cpnevwj7anmarue2@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8056"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 17 14:09:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFxul-0001sR-7M for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Aug 2021 14:09:55 +0200 Original-Received: from localhost ([::1]:60424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFxuj-0007ya-Oi for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Aug 2021 08:09:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFxtb-00076s-0x for emacs-devel@gnu.org; Tue, 17 Aug 2021 08:08:43 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:41712) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFxtZ-0003QF-IL for emacs-devel@gnu.org; Tue, 17 Aug 2021 08:08:42 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id x10so21944706wrt.8 for ; Tue, 17 Aug 2021 05:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=bYR3bG8mNV5RyR8N9mv7pXPL9OOUdGjjx8T2bEggeYs=; b=ofYpzU/YSkEb3lUwSOCzKEHkX6i/2sNKCSsDD13ezkxgOOZ9TKac7xABtHO+oSg3Yr 2yrVm/eWfw42eov0VQaroHTehJUzrEDQ12xGBn8DZzWSMRHO5YPvpFgN4JACzo2XkqSe qGthY+KqQ0klrnEy1qNrbRbKnwMSvzfuPAy5apmm6ZovBfPJyBTDWf0XW3DmLHtaYOjA q18niFKNYpjBxjhXovxMm3Hn8ZOWt5iNI9TRnAg4lTU58otrXHHDUVv3eM3qPzejIgu2 t/KEnzpKeGkNiLX8MKFx2F+vb+YP/PH1ck4rf4gYGHKYcP3gn2E+NXslZKFHZFNt9KxP /sYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=bYR3bG8mNV5RyR8N9mv7pXPL9OOUdGjjx8T2bEggeYs=; b=NRFwjwouRZ5VMuxz6tZ0VGEiC1JEP6bKpE7PDM9RP4Tq5aeVcwRnVELYF521iAA9DX DBfu2jCEmDcGAov4w5+jS+VH844nYy8fFqtsVgH+84eZ7gqbQjA640apIkxZJqwwLz/n bWgQVU3FerOCrI0nkxU4NlBbyZdQgnDDcPgta1POZYlCQd9rg59vWY+U5SirLDYKNk1c YqkuDfEOwnAmAE8Px9I0qjLtaSfsY1HL1JkUHI372PgiVU90zvrCY0EjJz4Kr8OB8luC zwmytXkCaseluDaWUBivuB9wSUYYkdbOczuSLHY8zFqo3P2bHb9xSDBiPdSYYPbpm4zX x8fQ== X-Gm-Message-State: AOAM532XrHsWJMM3BL4zp0C9CqX/uvXpH5Xh4bzdrRGhI3xGybzaQ+T9 hpGel5bP2tvZy6WlDNP/RG//kvb3kbg= X-Google-Smtp-Source: ABdhPJxv7M+YQg39gIKV+HlBMjUE3gedKg4TpPtRHpIIFdJajHcst0vQmGyY+C1BaQEgVI3WW1t1pw== X-Received: by 2002:adf:aac9:: with SMTP id i9mr3562949wrc.231.1629202119450; Tue, 17 Aug 2021 05:08:39 -0700 (PDT) Original-Received: from krug (a94-133-27-132.cpe.netcabo.pt. [94.133.27.132]) by smtp.gmail.com with ESMTPSA id y10sm2056813wmo.18.2021.08.17.05.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 05:08:38 -0700 (PDT) In-Reply-To: <20210817000745.cpnevwj7anmarue2@Ergus> (Ergus's message of "Tue, 17 Aug 2021 02:07:45 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272487 Archived-At: Ergus writes: > I just tried the new fido-vertical you added. I added it some time ago, IIRC. What I've done very recently is make it enable fido-mode automatically, so that you don't need two foo-mode calls to get the desired functionality. So M-x fido-vertical-mode is all you need. > I think there is a small issue very simple to fix. In vertical mode > either the right/left arrows and C-n/p may be switched with the actual > up/down and maybe C-r C-s... to have a consistent behavior. I had a tough time understanding what you meant, but now I think I do and I just committed the patch after my sig. If you use fido-vertical-mode, also notice the new goto-first/last stuff suggested by Simon Lang in bug#49005. Jo=C3=A3o diff --git a/lisp/icomplete.el b/lisp/icomplete.el index 96b7e0f201..81fc6ff03c 100644 --- a/lisp/icomplete.el +++ b/lisp/icomplete.el @@ -624,6 +624,8 @@ icomplete-vertical-mode-minibuffer-map (let ((map (make-sparse-keymap))) (define-key map (kbd "C-n") 'icomplete-forward-completions) (define-key map (kbd "C-p") 'icomplete-backward-completions) + (define-key map (kbd "") 'icomplete-forward-completions) + (define-key map (kbd "") 'icomplete-backward-completions) (define-key map (kbd "M-<") 'icomplete-vertical-goto-first) (define-key map (kbd "M->") 'icomplete-vertical-goto-last) map)