From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: What's the point of byte-compile-define-keymap? Date: Sun, 28 Nov 2021 14:30:32 +0100 Message-ID: <87czmk4dc7.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33078"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 28 14:32:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrKI6-0008Rk-Ii for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 14:32:26 +0100 Original-Received: from localhost ([::1]:52658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrKI4-0004rM-SR for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Nov 2021 08:32:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrKGT-0003jB-E5 for emacs-devel@gnu.org; Sun, 28 Nov 2021 08:30:47 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=35440 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrKGP-00014q-Kw for emacs-devel@gnu.org; Sun, 28 Nov 2021 08:30:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=10w8iGJDzpJT2yp4fJ3IY9JmILPpoJHN2n5Vk/BpqVs=; b=dXTw0EZfI9JzM+KD2pe0BxS7f1 LMYZcvL6Da8EEcK9KN8i7w1EiLpfuDJ04hSWO/sHz4AlOpSk0BagCAwx67MrCcKY9hhqsTAVjuVKK kCbRoZMDoCkLoneUTHdTeurSxhQeEL++/F85gbJASNabAZuaQq62gI5qVtIrrJl07Fi0=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrKGI-0002mN-8j; Sun, 28 Nov 2021 14:30:37 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEUDBA1NDBKsLxnM IRjYWSCZGRhtFxUwCREyJSGqXCByRiLbkSK2jjf///8XSKjxAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+ULHA0cM7Y9Vr8AAAFNSURBVDjL7ZGxUsJAEIY3DYtWiQOc9YXo2HqJjp1Ogg5jIwHOFmQIljlH PFsre8bmBkqHB2BoNE/g6EMZDWgIdBZa+Dd39+3t3f67AIvaYDZjDicyw3Om7TInIJjh0LXdOuMk iyHX8Nhu+3aJQ9GmlU1YoY5DL8kK3mf+drLDMFnzH3vRNva2krN2/l0WBgEvtfSED/TujAIIIoq9 ex1jZ3gni715AElADCnC9ekZXHsDPneOhjQkuRnrMDyBcmNCZp+DCCVoou7tw9rh1UX5WH5moJRh XB/27WiSfzyyaKcmjVTVWB9GUWHqHVRM3q2l7GFDVR+o55VNp2nxVEDz1emT5VDGmrSppzOYipRS 4x3LzDS+UFUvo9dnn1bCBQ6aq9ToTVHaWhqHz4OxbwVhNoAibossrZpI7Eik+VcuErJwP4TfEP78 iX/9Ub0DKe1K4CPRxFwAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTEtMjhUMTM6Mjg6NTErMDA6 MDCL98f5AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTExLTI4VDEzOjI4OjUxKzAwOjAw+qp/RQAA AABJRU5ErkJggg== X-Now-Playing: People Like Us - The Gimp's _I Don't Want To Be The One_: "Sometimes" In-Reply-To: (Alan Mackenzie's message of "Sat, 27 Nov 2021 16:36:47 +0000") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280407 Archived-At: Alan Mackenzie writes: > It looks to me that byte-compile-define-keymap (in > lisp/emacs-lisp/bytecomp.el) saves its FORM argument in ORIG-FORM and > always returns it unchanged. This looks like an oversight. It was rewritten from a byte-optimize function (but it doesn't optimise anything any more), so it should probably be cleaned up a bit more. > Also, would this function not better be named > byte-compile-FILE-FORM-define-keymap, since it is the value of a > byte-hunk-handler symbol property. > > Also[2], is this function really necessary? Is define-keymap used > sufficiently often to justify a special byte-hunk-handler for it? It just used to issue warnings for invalid keymap syntaxes at compile time. And, yes, it will be used everywhere. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no