From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 28.0.90 is out Date: Thu, 09 Dec 2021 18:31:19 +0800 Message-ID: <87czm6ax3c.fsf@yahoo.com> References: <875ys3qr0o.fsf@yahoo.com> <8335n748sj.fsf@gnu.org> <87wnkjpaff.fsf@yahoo.com> <831r2r47lk.fsf@gnu.org> <87sfv7p9uw.fsf@yahoo.com> <83zgpf2mdr.fsf@gnu.org> <87fsr6pn9r.fsf@yahoo.com> <834k7l3nko.fsf@gnu.org> <87o85tlv9o.fsf@yahoo.com> <87a6hdlukl.fsf@yahoo.com> <83pmq925hc.fsf@gnu.org> <87tufljldf.fsf@yahoo.com> <87pmq9jh21.fsf@yahoo.com> <83k0ggzg6v.fsf@gnu.org> <87r1angb8d.fsf@yahoo.com> <838rwvxofc.fsf@gnu.org> <877dcfdy7a.fsf@yahoo.com> <83mtlbw75d.fsf@gnu.org> <8735n2cyui.fsf@yahoo.com> <83k0geuoi1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29040"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 09 11:33:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvGjs-0007N4-Ui for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 11:33:25 +0100 Original-Received: from localhost ([::1]:42070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvGjs-0002hl-0D for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 05:33:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvGi8-0000nV-CN for emacs-devel@gnu.org; Thu, 09 Dec 2021 05:31:36 -0500 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:42006) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mvGi4-0005fV-LZ for emacs-devel@gnu.org; Thu, 09 Dec 2021 05:31:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639045890; bh=Mdc1QjtHHSiOA7muqCYiEKhYZrVRNplh+yN5/PPle08=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ZB70uKgl0DFA35pfXo0JsRUicjTco4GHXDoYL3gC3JtplobNOorYYuemNg//aSoeumwZbxGQ4t4huk1KZKLJ8aGdryN5uXzil5vtZQAFHORx3HuEY1v1EGwHuNCqeoepYKYhIwA78dd0EqpvnyONFTO9LrcrfbwVAe/ZPn8uBlfoEhnD44cU024kSKmR9kW8YTYu3dK24qCNAyzOZLeowgZPbG4vKIN2g3n2OneE1M/1B956Z3OG7lZUqqKEAsVlvunrkJqGuZyWc3yKd4WueRs2Csc22qk1+Y7hG+N27hAZy3KNNyDQDJNJa5sUTtTPTSgTLsPKtWqrVsuM6SGNoQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639045890; bh=ulpGMXPiyS43yRjnBpdKZLGOHeBs368ac7uCIdYUOtd=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Bp4JPqyku82H/5BP021nE2gaOY/YZktwX0vujuhj3Js0yu4eitVS+VY4pXRm8MXTbYsmJxiBB8op8O8a/ZhOnEHlJ5mUELDz2kBCQZFn1mZAgXtl7dCErabnt3JR3Swe6vc5Om6/PubcnqGHGpcCa8gRppQE+ff40U1DHxsGNSrYRGI0fQqwV6CNiCa5xgdwo0vcB134fYyY77cSqZq4KhziRUrJXWute6dmnLpRbDInOGMCCrK1Yt2P2BPCXdPu9DjN7Pd1hPEjCs1XXTAjepPV76GSwNXVqBbvz2mV5EAtD1cavf/gM1JdoeOfiBGK17ZU3ZqttYNvKFCpFrruoQ== X-YMail-OSG: BdmevrIVM1nRRa7kifkDiYGzXagrcVBoclWs1cSrihehDduhYEioN_.plyDwww7 Ji2iVKZzki4gQkH4aTTakHO.3ZhQqiw9Pt68dKrnryxOBBQ0h.FLCbYPj8iHpTjEyGMQb_JphsZJ 6Z6rIMvBAvBn4HIMHQUGwXPnoMQEEh2bdU.zVz8vX1Pnz3crw50S_RMOXKVUj7Bpr7_KRghqJnVS IhPuuw_y8b7yoiOKuR8_8zcSrNenWDZPeyEgTd2FI4VqsXqddPEt29vCSj0kQ9fwSaMskM8.3zAW XvTSKX4mec7IRy9rwBmif9bT.M2pKrRNS7bpwAclQ6Keoqp8DZcmkUhN1oRRkpEL71aF9X7A9qhT pV_68KyXamX4V2AjMqTjt7bjT9gnWRisO0JyxI2j7VrMEPDpjIfTesYAgesD7FFQSe2eQAmvk_Eg azfFeR85XMyYbF8PX9chmk5nByS7xZdT2VVQGQgjXkedhjS3aFtzxmSpgjPbobpedsR2LwqIwkU9 OibMwqV_E0YYI_aipLDSyyGz8gEfCAyDOEfDAWOD1WQquA5XzMZ5dHKqpesWQOQGd0yXVtv.L9st T8tckOuIimi2uTWco_IW4KNbExHMhEiUYPTJreudMZHQwH8nfDzHe7hl4NhMOo0KesqfBbLRn96X qEFLKLRPa0uGtIQ_IoTeLMXmyD4j.VhH00Akvz7dYoJ7etZFtuVQN2JD_ym93dsqFUp0nikbvoE. Wg8NxV0G04BpqkcBldPDEIrbXsw7r4BKKjeY2qeY7QfNPQfPUkQgM5.wo5KDTHLjwPRqfJ6WHOls UJfJcu5HMMUNTi2c7zhnxkG_fa0Ptd.kRgVB0HQDPG X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Thu, 9 Dec 2021 10:31:30 +0000 Original-Received: by kubenode502.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 13c79176d27a51c37a3e50250ec088fc; Thu, 09 Dec 2021 10:31:25 +0000 (UTC) In-Reply-To: <83k0geuoi1.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Dec 2021 11:16:38 +0200") X-Mailer: WebService/1.1.19415 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.204; envelope-from=luangruo@yahoo.com; helo=sonic311-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281478 Archived-At: Eli Zaretskii writes: > There's at-func.c in lib/, which implements the *at functions. But > msdos.c was emulating them on its own, see readlinkat, faccessat, and > other similar functions there. Their code is quite boilerplate, so it > shouldn't be hard to add a couple more of them. You can use the code > in w32.c as inspiration (but without the conversion of file names from > UTF-8). That should take care of openat and fchmodat. > I wouldn't recommend implementing copy_file_range, unless you mean the > trivial implementation that returns an error indication, like the > Gnulib version does. Thanks, I made the part in fileio.c that makes use of it conditional on !MSDOS, so on MS-DOS it will fall back to using read/write instead, > As for the rest, my recommendation is to implement futimens based on > DJGPP's setftime. Thanks, but I'm confused with the DJGPP `struct ftime': do I have to take leap years and the different lengths of each month into account when setting the various members of a `struct ftime' from a time_t? The comment here makes that uncertain: struct ftime { unsigned ft_tsec:5; /* 0-29, double to get real seconds */ unsigned ft_min:6; /* 0-59 */ unsigned ft_hour:5; /* 0-23 */ unsigned ft_day:5; /* 1-31 */ ^^ unsigned ft_month:4; /* 1-12 */ unsigned ft_year:7; /* since 1980 */ } Alternatively, is there some function I overlooked that populates `struct ftime' from time_t?