From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 2c79a8f 2/2: Use posix_spawn if possible. Date: Wed, 02 Feb 2022 09:30:44 +0100 Message-ID: <87czk5brgr.fsf@gmail.com> References: <7CFD5E28-8266-4004-BF66-255146D72722@gnu.org> <83r18whunp.fsf@gnu.org> <36bbd45c-0a87-13b7-1589-afe943329e20@fastmail.com> <83ee4whqpf.fsf@gnu.org> <87v8y33hu1.fsf@rfc20.org> <83sft7aqxd.fsf@gnu.org> <3db6c69c-0c08-3f92-491b-0b715b18eb40@fastmail.com> <87pmo6c3h6.fsf@gmail.com> <87h79ibdck.fsf@gmail.com> <83mtja74b1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29049"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, emacs-devel@gnu.org, sauliusmenkevicius@fastmail.com, p.stephani2@gmail.com, matt@rfc20.org, mituharu@math.s.chiba-u.ac.jp To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 02 09:49:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFBKQ-0007N2-Uj for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Feb 2022 09:49:26 +0100 Original-Received: from localhost ([::1]:45610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFBKP-0004ZA-5z for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Feb 2022 03:49:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFB2n-00019T-4o for emacs-devel@gnu.org; Wed, 02 Feb 2022 03:31:13 -0500 Original-Received: from [2a00:1450:4864:20::331] (port=51898 helo=mail-wm1-x331.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFB2R-0006Dx-Nc; Wed, 02 Feb 2022 03:31:12 -0500 Original-Received: by mail-wm1-x331.google.com with SMTP id i67so22863wma.1; Wed, 02 Feb 2022 00:30:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=oEhpxKpST4GL2nJWAF1NGyU+uPiAqIao3w0GKWne1AU=; b=hU4GplsGmAmFSyxcHqmBXY/njomqqFRFI9XOwwCd3QJbHcHEW/qRglemN5CyrTtUaK beR/NNkSI3CkGXEXysUkQk3Yf6+JtOtM9AEblwSrotcqNz3OaRcd1IOqUU27lIZTwnr7 HgTJCYt+lyA53i4trRj8HRcBSLeDcmBpYoGBT7quMkoKYLxddOq/RbHgJ5kvV3Krcu5L 9K3K2oGs1C0c6ijM62Myis/TnVtRtWdsnJeaspR1ngQ9J9Ct/q5/EOmJOIhVZRMvyIOs o5OzHQ/OeWfcP5uUrVa47SbkMR3TBmYjSGqs0Q4o6IoGV1bp//HDUhdJ0DLioinbXFiR 1D7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=oEhpxKpST4GL2nJWAF1NGyU+uPiAqIao3w0GKWne1AU=; b=0H44IIv5axxI0CcL8pPRAHpuO/2MYCV+TdEm9tgq7o/XHucZoyqXM3y2TNOA70pEAw kOuhC/ypvZCa5IbedNaMQZ3B/aTqIbwezZ51zBAwxe6xuoEMzkTl9RtMYG5Dq88NwpGI aaQsEifVr6aEK+IYoPTE741nqoUBB6ojltPLYnuPVYUBHvhII3MbcKIJ0XjoKvlLGz67 MxyZvwth8EuVxaSV6CqnDBISM5WGQYVdB9yMvs5MgC9MHKs+vuLnkn8GRA8fkvhBG9ig wXN3H/6ekVCOwFxuRhiTCmhw5ZZMGMm/kfzT3YzJp9ZfywfENnnW0GIgJIbR3iASJFAp aQmA== X-Gm-Message-State: AOAM532q1c1RX3DZzM0ym8JZHit+Ql39ZW8vtZGVi2JARzO4k40PM+vw NMoLQC5Lyqewfd6IF/zwKV4IQx2tGYE= X-Google-Smtp-Source: ABdhPJzzT2YZMUmqEOemCuh6wZOTGXIR864y9f8CyWJ+wzt4d6aHEvTSWcAbGSeBuuToEmikfEAeOQ== X-Received: by 2002:a05:600c:8a9:: with SMTP id l41mr5212017wmp.51.1643790645795; Wed, 02 Feb 2022 00:30:45 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:ad55:8544:ae5f:f0d2]) by smtp.gmail.com with ESMTPSA id ay3sm4035551wmb.44.2022.02.02.00.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 00:30:45 -0800 (PST) In-Reply-To: <83mtja74b1.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 01 Feb 2022 21:52:18 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::331 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=rpluim@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285775 Archived-At: >>>>> On Tue, 01 Feb 2022 21:52:18 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Eli Zaretskii , Matt Armstrong , >> p.stephani2@gmail.com, alan@idiocy.org, mituharu@math.s.chiba-u.ac= .jp, >> emacs-devel@gnu.org >> Date: Tue, 01 Feb 2022 20:23:23 +0100 >>=20 >> >>>>> On Tue, 1 Feb 2022 20:30:18 +0200, Saulius Menkevicius said: >>=20 Saulius> Thanks Robert! Saulius> I applied your patch and that has actually has fixed the issue= . So I Saulius> suggest this patch be applied on master. >>=20 >> I can do that, if Eli/Lars agree. Eli> Are there any downsides to the patch? If not, I see no reasons no= t to Eli> install that. Not as far as I can tell, but I shall test on a few more platforms before pushing. >> What should we do for emacs-28? Eli> Nothing, because on emacs-28 we use posix_spawn only on macOS. Right, I=CA=BCd missed that, master it is then. We could put it in 28.2, I guess, but I hadn't noticed any issues with subprocesses on emacs-28 on macOS. Robert --=20