unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 5743b74d4b 1/2: Improve mouse dragging
@ 2022-05-12  7:31 Eli Zaretskii
  2022-05-12 12:03 ` Po Lu
  0 siblings, 1 reply; 27+ messages in thread
From: Eli Zaretskii @ 2022-05-12  7:31 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> branch: master
> commit 5743b74d4b2e06ace233d6b170f193a72633f218
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
> 
>     Improve mouse dragging
>     
>     * lisp/mouse.el (mouse-drag-and-drop-region-display-tooltip):
>     Respect foreground and background parameters.
>     (mouse-drag-and-drop-region): Enable fine grained tracking.
> ---
>  lisp/mouse.el | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/lisp/mouse.el b/lisp/mouse.el
> index 0446bc6dd8..4b5f6ed223 100644
> --- a/lisp/mouse.el
> +++ b/lisp/mouse.el
> @@ -3017,7 +3017,15 @@ highlight the original region when
>    "Display TOOLTIP, a tooltip string, using `x-show-tip'.
>  Call `tooltip-show-help-non-mode' instead on non-graphical displays."
>    (if (display-graphic-p)
> -      (x-show-tip tooltip)
> +      (let ((params (copy-sequence tooltip-frame-parameters))
> +	    (fg (face-attribute 'tooltip :foreground))
> +	    (bg (face-attribute 'tooltip :background)))
> +	(when (stringp fg)
> +	  (setf (alist-get 'foreground-color params) fg)
> +	  (setf (alist-get 'border-color params) fg))
> +	(when (stringp bg)
> +	  (setf (alist-get 'background-color params) bg))
> +        (x-show-tip tooltip nil params))
>      (tooltip-show-help-non-mode tooltip)))

Maybe I'm missing something here, but this seems to force the faces of
the tooltip frames to follow the attributes of faces of the frame that
is the selected frame when the tooltip is shown.  Since faces are
per-frame, why is this a good idea, and what problems does the above
change attempt to solve?  (And why do we force the border color to be
the same as the tooltip-frame's foreground color?)



^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2022-05-14  0:56 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12  7:31 master 5743b74d4b 1/2: Improve mouse dragging Eli Zaretskii
2022-05-12 12:03 ` Po Lu
2022-05-12 12:47   ` Eli Zaretskii
2022-05-12 13:02     ` Po Lu
2022-05-12 13:12       ` Eli Zaretskii
2022-05-12 13:20         ` Eli Zaretskii
2022-05-12 13:25           ` Po Lu
2022-05-12 13:23         ` Po Lu
2022-05-12 13:51           ` Eli Zaretskii
2022-05-13  0:27             ` Po Lu
2022-05-13  6:00               ` Eli Zaretskii
2022-05-13  7:05                 ` Po Lu
2022-05-13  7:36                   ` Eli Zaretskii
2022-05-13  7:49                     ` Po Lu
2022-05-13 10:32                       ` Eli Zaretskii
2022-05-13 11:10                         ` Po Lu
2022-05-13 12:08                           ` Eli Zaretskii
2022-05-13 12:45                             ` Po Lu
2022-05-13 12:48                               ` Eli Zaretskii
2022-05-13 12:16                           ` Eli Zaretskii
2022-05-13 12:46                             ` Po Lu
2022-05-12 15:49       ` [External] : " Drew Adams
2022-05-13  0:28         ` Po Lu
2022-05-13  1:49           ` Drew Adams
2022-05-13  3:42             ` Po Lu
2022-05-13 15:30               ` Drew Adams
2022-05-14  0:56                 ` Po Lu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).