From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New packages: popon, corfu-terminal, flymake-popon Date: Sat, 21 May 2022 08:05:11 +0000 Message-ID: <87czg78g5k.fsf@posteo.net> References: <87leuyc1uz.fsf@disroot.org> <875ym18ku9.fsf@disroot.org> <874k1jahlu.fsf@posteo.net> <87pmk77326.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30410"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Akib Azmain Turja Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 21 10:09:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nsKBI-0007kw-Av for ged-emacs-devel@m.gmane-mx.org; Sat, 21 May 2022 10:09:48 +0200 Original-Received: from localhost ([::1]:37772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nsKBH-0006xT-AN for ged-emacs-devel@m.gmane-mx.org; Sat, 21 May 2022 04:09:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsK6v-0004eH-Jj for emacs-devel@gnu.org; Sat, 21 May 2022 04:05:20 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:50557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsK6t-0008AU-4v for emacs-devel@gnu.org; Sat, 21 May 2022 04:05:16 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B4E5324010A for ; Sat, 21 May 2022 10:05:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1653120312; bh=Bkt8w0nFEgllOO+zWbOfN2cnGm3Y6uV2JJmR0hs0v1Q=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=URnBxljCP7WxNVfTce0ilnDYaItAepXyKZ+XkEvuB3fDenELnKYqSeSB9FApOojJ5 1tF5zv0PYKWShad1/CY6zu3edpmhx1+KxxYrUQ/TZSF7j89K/eyMmFOeow2w45sy7W wMxt6imH5gqGk7A/i8ucOsm3Nr0bkwQSskjixYlgOYsRhg5y95RUve1H06QK0NsWGy sAMDWAnUex/by8BXu1dzzOF0Ep0Q0dJZJtjhNKnTUP53CTfXG/YDRi932hVo7LApfN uHetkn+lcwTZAsbxe7eah/LYBz2wRIVPDb0LVZNnX8jPhEqYwV+xJLwmwudyxJufuK lRn3dU/jBW8gQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4L4x3D0qcNz9rxB; Sat, 21 May 2022 10:05:11 +0200 (CEST) X-Hashcash: 1:20:220521:emacs-devel@gnu.org::fSo3vNhgaYreeuBV:0000000000000000000000000000000000000000001Fv4 X-Hashcash: 1:20:220521:akib@disroot.org::cM90wkkD6TSSdB3w:04QwW Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87pmk77326.fsf@disroot.org> (Akib Azmain Turja's message of "Sat, 21 May 2022 13:33:21 +0600") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290036 Archived-At: Akib Azmain Turja writes: > Philip Kaludercic writes: > >> Akib Azmain Turja writes: >> >>> Akib Azmain Turja writes: >>> >>>> I would like three new packages to NonGNU ELPA: popon, corfu-popup and >>>> flymake-popon. >>>> >>>> Popon is a popup library. It shows floating text, which doesn't move >>>> while scrolling, and even go away when switching buffer. >>>> >>>> corfu-popon provides a global minor mode to make Corfu (an ELPA package) >>>> use Popon instead of child frame. This allows to use Corfu in >>>> non-graphical displays. >>>> >>>> flymake-popon provides a local minor mode to show a popon (popup) on >>>> cursor hover containing Flymake diagnostics. >>>> >>>> -- >>>> Akib Azmain Turja >>>> >>>> This message is signed by me with my GnuPG key. It's fingerprint is: >>>> >>>> 7001 8CE5 819F 17A3 BBA6 66AF E74F 0EFA 922A E7F5 >>> >>> I have changed the name of corfu-popup to corfu-terminal, since that >>> name is somewhat misleading. >> >> I think this is preferable. One last point is that I see you have >> images in your repository. These should preferably not be distributed >> with the package. They can be removed on ELPA's side by adding a >> :ignored-files key, or on the repository side if you add a .elpaignore >> file that functions like a .gitignore file. I think the latter is >> preferable, in which case you don't have to patch nongnu.git if >> something minor changes on your end. > > Ok, I have commited "*.png" to corfu-terminal. I think that pattern > should ignore PNG files. Ok, it looks good. My local ELPA checkout seems to have no issues with the packages. Just don't forget to bump the version tags, for otherwise ELPA will distribute older versions of the packages. I will wait a day or something like that before pushing the changes, in case someone has objections or comments.