From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master ee6e4bc525: Update device-specific grab during drag-and-drop Date: Sun, 21 Aug 2022 15:03:10 +0200 Message-ID: <87czctn3zl.fsf@gnus.org> References: <165594564645.17861.9851899361770628544@vcs2.savannah.gnu.org> <20220623005406.BF9E6C01682@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40611"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu To: Po Lu via Mailing list for Emacs changes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 21 15:04:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPkcX-000AMt-86 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 15:04:05 +0200 Original-Received: from localhost ([::1]:41002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPkcV-0002S8-Fv for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 09:04:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPkbm-0001bU-Pv for emacs-devel@gnu.org; Sun, 21 Aug 2022 09:03:18 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:59934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPkbl-0005LN-3N for emacs-devel@gnu.org; Sun, 21 Aug 2022 09:03:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4ecgU3lxCYXdiZYdZrwjxHlEcLOAgSZZ+WHo1ZvU4K4=; b=UBiQXQzxj64KnLooqtmSU5FwTp 0M14pF73mYsbElM3dWzRnzvtlUYruPGImK2vWMZb9y0Yy9FP2inN5SiasB6JQ8YJnqupWe1ddWFd8 Fw8GRNfFefqOonbS3gG5qS/01rTSFNfmOWUidc8IznltQrESaAspjDceu6TU/R1cG1WM=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPkbe-00024P-Ut; Sun, 21 Aug 2022 15:03:13 +0200 In-Reply-To: <20220623005406.BF9E6C01682@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Wed, 22 Jun 2022 20:54:06 -0400 (EDT)") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEWdkXFgYltBNSxv gX6urpL////1g5C3AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YIFQwtKqn11A4AAAGISURBVDjLdZPh kYQgDIXhoAACV4BQAcgWwI70X9O9BHTVc/PDGfKRl5BEpa5GbAn2zT+B/sEZXv8AioB4A1eprzn8 HdBufgJTqLIRhVpD7/09gaYTeF1AGCCAnYEJNbzs9h9o3M6qllCRrB/AKgOgACBW6QDNtgFMgFLN B+i9aZIIgCJFTdAkh6r8naBMYPrGUgBBlDYBrXcGmkYm+BE4cwCQDiajQlwrs1eWQXf8nmb10nUa fUcwcvRsM3RKWt4+0ZAaYHPZKEgsKUUKEmG5qt7IKi8DinGXQqEvPNLhxI7Ic/8AYxw2QULSBSDx mhh4BuUETGBpdt9BphX3JcsH1K6ckWP6Byx6PHLz/sR9tI03hR3k0Ftp1ogA4KctRL8dW/aRyuot b9ZRnkGobYKApoY17T1B3SNHFv4BR47sXMh63TuyV6UwCl6vZ6BOYP8NMDxXz0C6i2kTRyD/FcBB bvxRZW+JSHEnNJ1stlIRPXjvwMdH4GnsyQRjAHL5JCQgzZFeTaUv9gchl3huqTRFngAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMi0wOC0yMVQxMjo0NTo0MiswMDowMOlPQIkAAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjItMDgtMjFUMTI6NDU6NDIrMDA6MDCYEvg1AAAAAElFTkSuQmCC X-Now-Playing: Latin Quarter's _Modern Times_: "Cora" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293694 Archived-At: Po Lu via Mailing list for Emacs changes writes: > Update device-specific grab during drag-and-drop > > * src/xterm.c (x_detect_focus_change): Fix typo. > (handle_one_xevent): Set device if DND is in progress and update > device->grab. This (or something other change in this area) leads to the following warnings in an --with-x-toolkit=no build on the current Ubuntu: xterm.c: In function 'handle_one_xevent': xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference] 21537 | device->grab &= ~(1 << xev->detail); | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ xterm.c:21537:40: warning: potential null pointer dereference [-Wnull-dereference] 21537 | device->grab &= ~(1 << xev->detail); | ^~ I haven't checked whether it's a correct warning or not.