From: Payas Relekar <relekarpayas@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Progress on merging Eglot?
Date: Mon, 19 Sep 2022 14:39:39 +0530 [thread overview]
Message-ID: <87czbriv18.fsf@gmail.com> (raw)
In-Reply-To: <CALDnm52QEYNbV5OpM1tOoLpk0zdstH-L=CpX7ziXnBjWKujkaQ@mail.gmail.com>
João Távora <joaotavora@gmail.com> writes:
> I haven't had the to look at this in depth, but this looks mighty fine,
> including this last idea of putting two "fixes" found in the subject line
> in two lines of the body.
>
> On Mon, Sep 19, 2022, 05:42 Payas Relekar <relekarpayas@gmail.com> wrote:
>
>> Another way I can think of is to keep #nums where they are right now,
>> but add their respective links in the message body below.
>>
>> e.g.
>> Fixes #234,#456
>>
>> this fixes two issues
>>
>> Becomes =>
>>
>> Fixes #234,#456
>>
>> this fixes two issues
>> #234: https://github.com/joaotavora/eglot/234
>> #456: https://github.com/joaotavora/eglot/456
>>
Alright! I think we have everything we need. I took the append URLs to
bottom of commit message approach. Here's what we have:
- History visible for file lisp/progmodes/eglot.el
- Commit message length undisturbed
- every #num is appended with appropriate URL at the bottom of commit
message
These are the latest and (hopefully) final URLs:
Code:
https://gist.github.com/bhankas/422c34db2e987d4dc3f243e26ba156a3
(Please ensure eglot2emacs.py is in same directory as eglot/ and emacs/
repos)
Emacs repo with eglot.el merged:
https://github.com/bhankas/emacs
eglot.el file history within merged emacs repo:
https://github.com/bhankas/emacs/commits/master/lisp/progmodes/eglot.el
If all is good, that concludes #2 on João's list.
Let me know for any corrections and/or improvements.
Thanks,
Payas
--
next prev parent reply other threads:[~2022-09-19 9:09 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 16:48 Progress on merging Eglot? Payas Relekar
2022-09-08 17:09 ` João Távora
2022-09-08 17:09 ` Payas Relekar
2022-09-08 17:16 ` João Távora
2022-09-08 17:26 ` Payas Relekar
2022-09-18 16:31 ` Payas Relekar
2022-09-18 20:30 ` Philip Kaludercic
2022-09-18 20:47 ` Dmitry Gutov
2022-09-18 21:00 ` Philip Kaludercic
2022-09-18 21:11 ` Dmitry Gutov
2022-09-18 21:13 ` João Távora
2022-09-18 21:12 ` João Távora
2022-09-18 21:20 ` Philip Kaludercic
2022-09-18 21:24 ` João Távora
2022-09-19 2:37 ` Stefan Monnier
2022-09-19 4:25 ` Payas Relekar
2022-09-19 4:42 ` Payas Relekar
2022-09-19 7:23 ` João Távora
2022-09-19 9:09 ` Payas Relekar [this message]
2022-09-19 9:25 ` Payas Relekar
2022-09-19 9:17 ` Payas Relekar
2022-09-19 14:09 ` João Távora
2022-09-23 15:23 ` Progress on merging Eglot: update João Távora
2022-09-24 4:32 ` Payas Relekar
2022-09-24 7:05 ` Payas Relekar
2022-09-25 2:46 ` Richard Stallman
2022-09-25 3:04 ` Payas Relekar
2022-09-25 5:04 ` Eli Zaretskii
2022-09-26 12:10 ` Richard Stallman
2022-09-26 12:13 ` João Távora
2022-09-27 16:16 ` Richard Stallman
2022-09-19 12:25 ` Progress on merging Eglot? Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2022-09-19 16:32 Payas Relekar
2022-09-19 16:59 ` João Távora
2022-09-19 15:12 Payas Relekar
2022-09-19 16:09 ` João Távora
2022-09-19 13:11 Payas Relekar
2022-09-19 14:28 ` João Távora
2022-09-19 15:50 ` Payas Relekar
2022-09-18 16:55 Payas Relekar
2022-09-08 12:31 Payas Relekar
2022-09-08 13:09 ` João Távora
2022-09-08 13:55 ` Philip Kaludercic
2022-09-08 14:02 ` João Távora
2022-09-08 14:14 ` Philip Kaludercic
2022-09-08 14:24 ` Payas Relekar
2022-09-08 14:44 ` Philip Kaludercic
2022-09-08 14:47 ` João Távora
2022-09-08 14:54 ` Payas Relekar
[not found] ` <CALDnm50tiazUMnm9D3knBUCSLbT4FLvSPoX4ayUEmOtQSHbCtw@mail.gmail.com>
[not found] ` <87r10lor2c.fsf@gmail.com>
2022-09-08 16:08 ` João Távora
2022-09-08 14:26 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czbriv18.fsf@gmail.com \
--to=relekarpayas@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).