From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Amending commits Date: Sun, 25 Sep 2022 13:39:00 +0200 Message-ID: <87czbjbs4r.fsf@gnus.org> References: <87h70vbw2f.fsf@gnus.org> <877d1ru3rd.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19499"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "Emacs-devel@gnu.org" To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 25 14:19:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocQbo-0004u9-Us for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Sep 2022 14:19:45 +0200 Original-Received: from localhost ([::1]:41888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocQbn-0008R7-Qu for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Sep 2022 08:19:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocPyY-0000zL-Mf for Emacs-devel@gnu.org; Sun, 25 Sep 2022 07:39:10 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:47868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocPyV-0007Gy-TS for Emacs-devel@gnu.org; Sun, 25 Sep 2022 07:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zVpQTTsgHx4Vq5c4P1zeoaPgQPw4rOcmXuwd5Mjkc3Q=; b=a/J8KXm67NJko1ZsqyfMutKfi9 hiiBogLu8UV/A1CQtVu3ZcbdQGBDKrmXMQ+GflXswbJVpOryXwVKq3+k+PlHQUKLT9Qf28WJybpcO mHvYWY8oVK2YV7W1K+CzNnKeuYZbj8nRKydatldwwtbrVWqWH1Ku+5nZubsj9isYB4Qw=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocPyP-0005Qo-Vo; Sun, 25 Sep 2022 13:39:05 +0200 In-Reply-To: <877d1ru3rd.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 25 Sep 2022 10:50:30 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUrJi11nLmnL0aw Gi////+K8Yg8AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJGQslGjUM7icAAAG1SURBVDjLjZMJbsQg DEVZLoDpBQhcIAP3v1v//yZLpUqtpZk4ed4NIZoVKxFSi4VSzEK1YCEkI4oWD4MARJMSgiWrJVYC 8FLi/g4vAjesCMsQCCqQ7lC1lECbWByYHR4aBXgWxgoRCEKbBlCDqtpSwiNr+XOsFvLR6amvkHNr c/ANIK8tt4nMYn70n2DcOlwyMowHwOnMDqbyTw/FLPydDmDaHHQY9yFQJ5pe/HLG+k5e1+zTmOW0 rxtMjAyPj8Ah0MeuyvSp6r/gv+ULwKKVBB0zfedQlN4d5DUTVbZgd7tcB2MkH9VTioNJb+2o84Xu AOHKTAArTevQPu+hB9Y4CaJAGtf+3gLitbS946sSnLh6TSR4vnGBXaNAS6joS82Wa4mIVbKl9ald 4F504xCP0ad2Ex9AK6QznqDJw6ytt7CB70mdD9SAzHltUDVRdJh5+Hof20Nb+0QBP5cEpqOhWaFz KsM3aOOI3VNsUFUWljDRBRzCBmNohbAbHgmq+kDu9RHgfCYud5RHYy1NgAs9aG7sYKVUHXDAiq/7 piM378sXTdcRt/i9qD8k9dbSbyDy9v8jwDePd3DtvJKNeAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAy Mi0wOS0yNVQxMTozNzoyNSswMDowMHlQEi8AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMjVU MTE6Mzc6MjUrMDA6MDAIDaqTAAAAAElFTkSuQmCC X-Now-Playing: Talking Heads's _Remain In Light (vinyl)_: "Crosseyed And Painless" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296215 Archived-At: Philip Kaludercic writes: > I think that command assumed you have changes that you wish to add to > the last commit (so you couldn't just use it to reword a commit). You > start preparing a new commit using `vc-next-action', then when the > buffer appears you M-x vc-git-log-edit-toggle-amend to indicate that > this commit will be amending the previous one. So the commit message > gets replaced by that of the previous message. The rest just involves > finishing up like any other commit. Ah, I see. >> There should be a command in `vc-dir-mode' that allows you to amend the >> last commit, I think. > > That would be good, because it would also allow easier to reword a > commit that doesn't require any code changes. Yes. My use case is "git am" and then I want to add the bug# to the commit message -- and in that case, I don't have a log-edit buffer at all.