unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 69d1278527: ; Fix some doc strings in elisp-mode.el
Date: Thu, 17 Nov 2022 10:17:44 +0100	[thread overview]
Message-ID: <87cz9mx7lz.fsf@web.de> (raw)
In-Reply-To: <83h6yydnle.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 17 Nov 2022 09:52:45 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> Maybe I do, I don't remember.  But using it doesn't necessarily mean I
> can immediately understand the relation to what the doc string says
> (or doesn't say).

(info "(elisp) Instrumenting") describes everything completely and
correctly AFAIK.

Which means: EDEBUG-IT is the prefix arg and when it is specified, then
the top-level form to be evaluated is first instrumented, and then
evaluated.  Details seem to be slightly more complicated
(`edebug-read-and-maybe-wrap-form1'): defining forms are treated a bit
specially.  But that detail doesn't need to be explained in that
docstring.

`edebug-all-defs' non-nil reverts the meaning of the prefix arg of
C-M-x.  That probably should be added to the docstring.

The code... I can also only read the code, it's not trivial: when using
the prefix arg, edebug is first `requir'ed.  Loading edebug installs an
advice on `eval-defun' - that's why the recursive call of `eval-defun'
is not nonsense (you may want to add a comment to the code...).  The
advice's name is `edebug--eval-defun'.  And that works by advising
`load-read-function' to make it return instrumented code.

All only AFAIU.  Anything else I could try to answer in particular?
Maybe also Stefan wants to help...

Michael.



  reply	other threads:[~2022-11-17  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166853515177.10254.3755761779228774904@vcs2.savannah.gnu.org>
     [not found] ` <20221115175912.8BC26C00613@vcs2.savannah.gnu.org>
2022-11-17  2:36   ` master 69d1278527: ; Fix some doc strings in elisp-mode.el Michael Heerdegen
2022-11-17  6:53     ` Eli Zaretskii
2022-11-17  7:33       ` Michael Heerdegen
2022-11-17  7:52         ` Eli Zaretskii
2022-11-17  9:17           ` Michael Heerdegen [this message]
2022-11-17 10:34             ` Eli Zaretskii
2022-11-17 23:16               ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz9mx7lz.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).