From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 350918e7be: Adjust x_display_set_last_user_time for Xlib sign-extension Date: Tue, 22 Nov 2022 14:13:37 +0100 Message-ID: <87cz9f9loe.fsf@gmail.com> References: <166912189923.20568.14093477497390803497@vcs2.savannah.gnu.org> <20221122125819.904D2C0E4B5@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40956"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 22 14:14:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxT6W-000APc-Vo for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Nov 2022 14:14:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxT5r-0005RI-K9; Tue, 22 Nov 2022 08:13:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxT5p-0005R5-Qf for emacs-devel@gnu.org; Tue, 22 Nov 2022 08:13:41 -0500 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxT5o-00070z-50 for emacs-devel@gnu.org; Tue, 22 Nov 2022 08:13:41 -0500 Original-Received: by mail-wm1-x332.google.com with SMTP id t4so10667004wmj.5 for ; Tue, 22 Nov 2022 05:13:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=NglL1w/dCwj7PurryJh1EHsAaTjYINnhCioMNuWOwuI=; b=SfSTMbgH2wAexDTvYEFXcAixQmNo+yZl8bnOCuNxBkGqPaCzLUaNelTu0gPv49LIaO 4SMeZUq/UG5Ke+V7TWyZpBrUslWOxP9PeLIBp1GtB8euNnSXLsu2NgFDV2LyetxYMzvD Kyg5MDKDOOHBaza+j7h9s6juTvKqw/NFjlKdn+UiITitPaksDUPnYoSq4j11vjmzizuZ OKjTUdylNqSMbWJFnasx+6CaiV55ZJELES1J8RIFGMPZ0DFBnqF4T61eyTOfOSt81Vu/ rJcV7DQgoBAD/64wwrfN2Idb5ZcMQf6ye+cOf7AIh4Q6W6tXLcBCWyoUuNicEqSPWrAk enQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NglL1w/dCwj7PurryJh1EHsAaTjYINnhCioMNuWOwuI=; b=6eZvArnIHYFzvHiUVE8jUpdHZn3o/No+MG7ZGPB9Wp+v2kmTrkRm9Ouy5ZX7Q8w/MT JpT2XCSyf/ppsOSF4HAA35VR4qLLkmF7fdxjQ/kKyKT933vuG1ydPvasmEB7OQjUegrg My//uODpndW0ORtSDxeDX6rbthjwdmpJvWdLJdjLXRmmUvEf8UfM6YgN4gpjCU3JlMRv JqiVVXXjSTj64n/hlH4oTrP7SvlyInKtx5+c6OucLYaL3fBPywOKql6GQP7YJuKmLM8X C1HdH8moaFBRkAyqZrVOMTHA4ebySHFONNQB/hYBCgBHUss12R6L1/BD98upP3WUu2ix xlEg== X-Gm-Message-State: ANoB5pmq+9zkDyxQLiJX/LYL8N03oMNRgJSQf7hWyNzKgaqlSwgbjTUo vyNzvlPChcdEKpDw8YDaPK0= X-Google-Smtp-Source: AA0mqf6/fn67rGF3/JhbjHg30ulou2tfWdYm0t5TuuQ1lISyKIdWeLSzl288C3M/9mUxIlwjsvN1iw== X-Received: by 2002:a1c:6a04:0:b0:3cf:77cc:5f65 with SMTP id f4-20020a1c6a04000000b003cf77cc5f65mr9882515wmc.25.1669122818260; Tue, 22 Nov 2022 05:13:38 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id t3-20020a05600001c300b0022dc6e76bbdsm14127164wrx.46.2022.11.22.05.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 05:13:37 -0800 (PST) In-Reply-To: <20221122125819.904D2C0E4B5@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Tue, 22 Nov 2022 07:58:19 -0500 (EST)") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=rpluim@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300332 Archived-At: >>>>> On Tue, 22 Nov 2022 07:58:19 -0500 (EST), Po Lu via Mailing list for = Emacs changes said: Po Lu> + /* Time can be sign extended if retrieved from a client messa= ge. Po Lu> + Make sure it is always 32 bits, or systems with 64-bit lon= gs Po Lu> + will crash after 24 days of X server uptime. (bug#59480) = */ Po Lu> + time &=3D X_ULONG_MAX; Po Lu> + Po Lu> #ifdef ENABLE_CHECKING Po Lu> eassert (time <=3D X_ULONG_MAX); Po Lu> #endif You could even remove the `eassert' now, but it=CA=BCs a minor thing. Robert --=20