From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 7f53446: Doc fix for y-or-n-p; trailing space is no longer needed Date: Tue, 03 Jan 2023 16:59:45 +0100 Message-ID: <87cz7vk3ri.fsf@gmail.com> References: <20210916073852.6025.85941@vcs0.savannah.gnu.org> <20210916073853.B90BA20ABE@vcs0.savannah.gnu.org> <87mt6zk7v0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="611"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 03 17:00:43 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCjiU-000AZV-TR for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Jan 2023 17:00:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCjhg-0002Qj-4I; Tue, 03 Jan 2023 10:59:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCjhe-0002QG-AY for emacs-devel@gnu.org; Tue, 03 Jan 2023 10:59:50 -0500 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCjhc-0006PR-RM for emacs-devel@gnu.org; Tue, 03 Jan 2023 10:59:50 -0500 Original-Received: by mail-wm1-x330.google.com with SMTP id l26so21485856wme.5 for ; Tue, 03 Jan 2023 07:59:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=zIrUz981OxN54YK7nEGrOoBC7+p5ncyKuiy4VyG0eiE=; b=H6bsLa5o8g3hNMW8N37OS8vXjQSS8X587IZGAJ/VyiR8beITQ17tArDgMxSVI6cR72 C4uYUIZQnFCBpsQfoiOS7UPk8qa++MUjeIvfYQbAHI5GWI8BK80/9P5hn4vX5BXaZRIc KrplFvI0NTQTfvbkM6yOW6gmzB6bhbjhQIEt36rb92B18/gLGbdcFrHu8V8F/X9ofxmD O+qNvfxmqydAX8TjQkkT1I06Z2ur6DCso01DQ7vmOa/WT3eRKN04NF4EwaxuvRhjxe7I S7WxcpCQA7PADxQgQqrl1XoO9CfPeWvJkZEFQKMT/2BNegz/BwrC45Fwm2Kpt1rXET0B /4yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zIrUz981OxN54YK7nEGrOoBC7+p5ncyKuiy4VyG0eiE=; b=hd+hb9kp0m6WI0EpVl0WlHtkTXru7dt8aQzMKivZfLPucV5ckf7yMXkFOuHux0W9l/ 5AIeUgIAR3N6XewfQ3AVkfqCcNBFuGjmpZamdWzSf8Vp5zx8MN5u81fr0i7v8TPGQHOp weeTOMq+diMqJZ5aWUZk/97fmZQPtmTr1pX+VJiGi1tF6pldZlCRp9+Jgm8OMbSJan2S VYD3meH+Hq+n46rYCfptWVWQnCtJ0h28cCpqkr2QxAEN0xS30310ai9FjBN54eduQ88s bws312ao731KldEUsoEXJqaMenyxFhfWmIONGrdKiyZJVgELdN0FSn7CHHH/qImL4qC7 jH/A== X-Gm-Message-State: AFqh2kpkb/CeYiPrJEOa5g6ROn7m55FKNjaF76VuIqSHLQ9OMkOZjaJh Zi6QK3NJFUODN5U+ZgJotVQ4Yf0xH80= X-Google-Smtp-Source: AMrXdXvOVzLnwN/tbHCypWip5XzRF9qcMtlS9BzmVtqgVC+sIvv+jQ4yQad/fXiaUA3P2/dtfWBSnw== X-Received: by 2002:a05:600c:4d25:b0:3d2:27ba:dde0 with SMTP id u37-20020a05600c4d2500b003d227badde0mr32234188wmp.33.1672761586340; Tue, 03 Jan 2023 07:59:46 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id e8-20020a05600c13c800b003cfd58409desm45620139wmg.13.2023.01.03.07.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 07:59:45 -0800 (PST) In-Reply-To: (Stefan Kangas's message of "Tue, 3 Jan 2023 15:33:21 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=rpluim@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302216 Archived-At: >>>>> On Tue, 3 Jan 2023 15:33:21 +0000, Stefan Kangas said: Stefan> Robert Pluim writes: >>>>>>> On Thu, 16 Sep 2021 03:38:53 -0400 (EDT), stefankangas@gmail.co= m (Stefan Kangas) said: Stefan> * src/fns.c (Fyes_or_no_p): Doc fix to reflect that a trailing = space Stefan> is no longer needed; one is added or removed automatically. >>=20 >> I just tested this on master, and I don=CA=BCt think this is qute ac= curate: Stefan> Hmm, I guess you're right. Not sure what I was smoking: >> - `y-or-n-p' will append a space if there is one *isn=CA=BCt* one, I meant. This stuff is hard :-) >> - it won=CA=BCt remove one Stefan> (y-or-n-p "foo") =3D> prompt is "foo (y or n) " Stefan> (y-or-n-p "foo ") =3D> prompt is "foo (y or n) " I was thinking (y-or-n-p "foo ") =3D> prompt is "foo (y or n)" which we could consider fixing (but it=CA=BCs long-standing behaviour) >> - `yes-or-no-p' never modifies the passed prompt Stefan> (yes-or-no-p "foo") =3D> prompt is "foo(yes or no) " Stefan> (yes-or-no-p "foo ") =3D> prompt is "foo (yes or no) " Stefan> I think the best fix here is to change `yes-or-no-p' to work th= e same Stefan> way as `y-or-n-p'. ENOPATCH =F0=9F=98=9C (and as someone pointed out elsewhere `y-or-n-p' and `yes-or-no-p' could do with some refactoring. Robert --=20