Master: Searching for program: No such file or directory, ls

Master: Searching for program: No such file or directory, ls

[Michael Heerdegen]

Hello,

To save others the two hours of nervousness I had: Emacs master
currently doesn't find any system programs like ls (dired), sh (shell),
at least here on Debian, after Tramp has been loaded.

If this happens to you, your Laptop has _not_ died.  Instead this seems
to be caused by 907fd1f7ff4 "Improve Tramp file name completion."

If somebody can reproduce the issue, maybe we should revert that commmit
for now?


TIA,

Michael.

Re: Master: Searching for program: No such file or directory, ls

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Hello,

Hi Michael,

> To save others the two hours of nervousness I had: Emacs master
> currently doesn't find any system programs like ls (dired), sh (shell),
> at least here on Debian, after Tramp has been loaded.
>
> If this happens to you, your Laptop has _not_ died.  Instead this seems
> to be caused by 907fd1f7ff4 "Improve Tramp file name completion."
>
> If somebody can reproduce the issue, maybe we should revert that commmit
> for now?

I'm very sorry about this! As said in bug#60505, the appended patch
should fix it. Could people give me feedback, in order to install this
fix?  Unfortunately, I cannot reproduce the problem with the given
recipe.

> TIA,
>
> Michael.

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 601 bytes --]

diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 69812506e48..b75a1816fdb 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -2773,7 +2773,7 @@ tramp-completion-file-name-handler
   "Invoke Tramp file name completion handler for OPERATION and ARGS.
 Falls back to normal file name handler if no Tramp file name handler exists."
   (if-let
-      ((fn (and tramp-mode
+      ((fn (and tramp-mode minibuffer-completing-file-name
 		(assoc operation tramp-completion-file-name-handler-alist))))
       (save-match-data (apply (cdr fn) args))
     (tramp-run-real-handler operation args)))

Re: Master: Searching for program: No such file or directory, ls

[Michael Heerdegen]

Michael Albinus <michael.albinus@gmx.de> writes:

> diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
> index 69812506e48..b75a1816fdb 100644
> --- a/lisp/net/tramp.el
> +++ b/lisp/net/tramp.el
> @@ -2773,7 +2773,7 @@ tramp-completion-file-name-handler
>    "Invoke Tramp file name completion handler for OPERATION and ARGS.
>  Falls back to normal file name handler if no Tramp file name handler exists."
>    (if-let
> -      ((fn (and tramp-mode
> +      ((fn (and tramp-mode minibuffer-completing-file-name
>  		(assoc operation tramp-completion-file-name-handler-alist))))
>        (save-match-data (apply (cdr fn) args))
>      (tramp-run-real-handler operation args)))

That fixes the issue for me, thanks.

Maybe let's continue discussing in that bug#60505 thread.

Michael.

Re: Master: Searching for program: No such file or directory, ls

[Michael Albinus]

Michael Heerdegen <michael_heerdegen@web.de> writes:

Hi Michael.

>> diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
>> index 69812506e48..b75a1816fdb 100644
>> --- a/lisp/net/tramp.el
>> +++ b/lisp/net/tramp.el
>> @@ -2773,7 +2773,7 @@ tramp-completion-file-name-handler
>>    "Invoke Tramp file name completion handler for OPERATION and ARGS.
>>  Falls back to normal file name handler if no Tramp file name handler exists."
>>    (if-let
>> -      ((fn (and tramp-mode
>> +      ((fn (and tramp-mode minibuffer-completing-file-name
>>  		(assoc operation tramp-completion-file-name-handler-alist))))
>>        (save-match-data (apply (cdr fn) args))
>>      (tramp-run-real-handler operation args)))
>
> That fixes the issue for me, thanks.

I've pushed the fix to the master branch. Sorry again for the inconvenience!

> Maybe let's continue discussing in that bug#60505 thread.

Yep. As said yesterday, there are also some edge cases which wait for
correction. But these shouldn't be disastrous ...

> Michael.

Best regards, Michael.