From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Explain a bit more on how to configure language server in Eglot's manual Date: Thu, 16 Mar 2023 00:09:55 +0000 Message-ID: <87cz594kvg.fsf@gmail.com> References: <86sfeisu49.fsf@stephe-leake.org> <87356gvkkb.fsf@gmail.com> <87wn3jgof2.fsf@posteo.de> <878rfzt0h7.fsf@posteo.de> <833566ry3v.fsf@gnu.org> <87o7oudv7s.fsf@posteo.de> <87lejx6e1f.fsf@gmail.com> <87y1nxn1ia.fsf@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36345"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Michael Eliachevitch Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 16 01:09:11 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcbB9-0009DN-R0 for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Mar 2023 01:09:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcbA8-0001Uu-Py; Wed, 15 Mar 2023 20:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcbA6-0001UX-Ii for emacs-devel@gnu.org; Wed, 15 Mar 2023 20:08:06 -0400 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcbA4-0001QE-S2 for emacs-devel@gnu.org; Wed, 15 Mar 2023 20:08:06 -0400 Original-Received: by mail-wm1-x32a.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso2093703wmb.0 for ; Wed, 15 Mar 2023 17:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678925280; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VKT7bfURCFiy3yFMEfminrlroW6/SHQgkxqr0odvFYY=; b=LnJ2InRWNE6KaSL8WNkv4mYfLCovLW8Ni4KC5d29EuPLHNB3X3679/8R2IR0AP4Mk4 Gkqcr1bRJGOx3tGVnGX0hH98Z7wurUHXSgwLr1ceN0zRh4Ii8qN3HpF8P7x7zzSIZdpg /gYGWxGGjF3zZobYiooYWzPaJQn60EUCghB6PYIXaJDw4pVuttFzTqDJ7Jwvlo+il04p f9up7qt0DgfRa4XNsAQjsqX85tFpeTwPWzUaG/XHJN83dOz3TZC3qsk+szkTNaeGHjxa 2osrKLdYaX0eKQKzdbHS9swOvkrFzYdPwjc9tf+Ak8BnCM3nAho6ir2P91fgYNXYJT87 zZkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678925280; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VKT7bfURCFiy3yFMEfminrlroW6/SHQgkxqr0odvFYY=; b=IeYMENal5ScHbql3e76oxKnUWUAp1jlhOMUQ4XU8r/w3WyNih3uQml2t3x79OjOaoc pyDx6SblcY9XA64dWQhKS+G7KHU3KW41iJy5BjHNE1W8+1y3VXQlqAjM/Wb49Pyqtf6b 1GJGUh7i3m4QHD+VluspGhj5/0UDV4BAiD0X2ofVJR96GHYjkiZjYJI140336ry4vKSA xpTNfqmbukBiqC4JTaAW1RO68tMW3OHWJGVZNAuSnSTmNNdd1BhLx5O6jKBNttZfy7dF 5J8EOVgnEjGbXq6ysWcFkVveF0DMqedoZn+K9Q5LQgXrkQGlcfTU6/GZj/mR53cFcrkk p1Bw== X-Gm-Message-State: AO0yUKVWRsu9+CQTRytL0x8ICIuQuK9/mQ4LrUHaeQnShM3oQj7xJ1/9 /XR8Bhuwj4aUXS4FpF8iMgg4pmVf/UU= X-Google-Smtp-Source: AK7set9ACLS3yxqYzdQJ25DuE5S52R2mzVfIFqMokvofKO6uDY9EHliAUzm2vK/96rBUwyAcWqvfwA== X-Received: by 2002:a05:600c:45cb:b0:3ed:32bf:c254 with SMTP id s11-20020a05600c45cb00b003ed32bfc254mr4011992wmo.12.1678925279688; Wed, 15 Mar 2023 17:07:59 -0700 (PDT) Original-Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id d25-20020a1c7319000000b003ed2f755165sm3142138wmb.33.2023.03.15.17.07.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 17:07:59 -0700 (PDT) In-Reply-To: <87y1nxn1ia.fsf@posteo.de> (Michael Eliachevitch's message of "Wed, 15 Mar 2023 19:26:31 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304506 Archived-At: Michael Eliachevitch writes: > I would be fine with you editing the patch if you find some minor > things to improve or have a better idea for the example. Git commits > can have co-authors (this is what github does when you accept > suggestions from reviewers), but not sure how the typical workflows > are on emacs-devel (I just recently joined to keep up-to-date with > recent developments). Or should the patch submitter must aggregate all > suggestions into a final patch themselves? Separate patches is fine, especially if your're proposing different functional changes. Big salads less fine, but also accepted. I think most commiters know how to split patches. Here, I didn't because I was lazy, and it's a very small change. I've pushed your patch to Emacs 29 with a tweak to the commit message and a whitespace change, so I didn't add "Co-authored-by: Jo=C3=A3o T=C3=A1= vora <...>" like I sometimes do. > I'll try that soon. This patch changes just a couple of lines of > documentation, so I hope it's fine for now. Slowly I'm figuring out > this mailing list workflow and with the copyright assignment, there > would be no hurdles for larger contributions to Emacs in the future :) It's just email: there's much less to figure out than people think. Jo=C3=A3o