From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 0d5036061b5: Skip Eglot test if using very old clangd Date: Wed, 22 Mar 2023 12:51:59 +0100 Message-ID: <87cz51ngv4.fsf@gmail.com> References: <167942421231.13373.16122455155218245677@vcs2.savannah.gnu.org> <20230321184332.93736C13913@vcs2.savannah.gnu.org> <87lejpnk9t.fsf@gmail.com> <87h6udnip7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37860"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 22 12:52:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pex1U-0009j1-Qx for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Mar 2023 12:52:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pex0i-0004g0-SC; Wed, 22 Mar 2023 07:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pex0e-0004cd-RP for emacs-devel@gnu.org; Wed, 22 Mar 2023 07:52:05 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pex0d-00085t-9A for emacs-devel@gnu.org; Wed, 22 Mar 2023 07:52:04 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id p34so6305653wms.3 for ; Wed, 22 Mar 2023 04:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679485921; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=C1LtqzmbS6PP4HwfvF5JjjMR6jHeecqLMZCBYDsKhhQ=; b=FUpnvAGHP9YkvNROHYPvEeP9qO4G1SEik/47P7aB1VgrhMKI8b1i5THXjr0QUMN8Kd jIDob/up6+SAiXeQUcvtZEY+CBws7xyecTxWXwvHA0yr2Pj9snZkag2o6uiXDpv3nMCJ T9xs9GIoo44Hx+5qXRUX0TJVe6JshvZr9l4oggeEz0QttpcLZzX6f+pNn0CitqLpmCaC u7HPPbHfBnDp1qNO6/JcxMlIAVrAoh66Ts+1Hk9cwR6DknpTumi8NTFV3UawM4CI0XhK K89lXF5OJ/CmcgCyhz+uTf7vLzLpV2FfDNC79YYTQ6RgjNeHiPAASiDvyUSdVegryixH vusg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679485921; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C1LtqzmbS6PP4HwfvF5JjjMR6jHeecqLMZCBYDsKhhQ=; b=77k7eAMwqQeym+wA5UE+J9y/Q6mzeDwL4nB7JDsCunGydlWkIsztc4YBhcBOINi8pe IU2TcIud6x1QN5eBuH77PBaBEEd+ObXhoceTUZLE0g1Nt0xAzOg1kLfQ6NigYCejowRb A1JBZhgz5SzvOfPYJ95b+yqD7Tu7yghHa4CStlsae3PsrLDVFNYndBeJDLYPAcaWCyYZ URhi4osvq0cQsCRPgqdU3UjSzDdArFKKZtDx+49lMcZpgZxa3IG0+aIKU8Dj1EPJbRhs fAG0Dyo50brbh3TFS8SxX12DpliOrl7XeIH/viLdmXcGLYb+/PIUGOGmcOo3Jgb4xjXK EqyQ== X-Gm-Message-State: AO0yUKXhirX4rZx3U3P0Q3Udf8RBMf1wYu8z0jRlBF5lGB4Fq2rHaBat zJp+MxotVhWySl/w2zu3BGhpjAFjfT8= X-Google-Smtp-Source: AK7set/k7qAoOWoYyF6SdgMPh5jG2T5HxLKQD6PePEFBwgLiY+ryf31zHt1zlXNogsah/VP1RBshog== X-Received: by 2002:a7b:c4c7:0:b0:3ed:296b:4899 with SMTP id g7-20020a7bc4c7000000b003ed296b4899mr6049069wmk.15.1679485920848; Wed, 22 Mar 2023 04:52:00 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 10-20020a05600c230a00b003ed2384566fsm16523807wmo.21.2023.03.22.04.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 04:52:00 -0700 (PDT) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 22 Mar 2023 11:14:05 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=rpluim@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304709 Archived-At: >>>>> On Wed, 22 Mar 2023 11:14:05 +0000, Jo=C3=A3o T=C3=A1vora said: >> This doesn=CA=BCt care where 'version ' appears: >>=20 >> (defun eglot--clangd-version () >> "Report on the clangd version used in various tests." >> (let ((version (shell-command-to-string "clangd --version"))) >> (when (string-match "version[[:space:]]+\\([0-9.]*\\)" >> version) >> (match-string 1 version)))) Jo=C3=A3o> Looks good, can you push? Done Jo=C3=A3o> I wonder why this is so difficult Jo=C3=A3o> to do with replace-regexp-in-string. It=CA=BCs because we don=CA=BCt have a 'really-match-everything' version of= '.', so you end up with (replace-regexp-in-string ".*version[[:space:]]+\\([0-9.]*\\)\\(.\\|[\n\r]\\)*" "\\1" (shell-command-to-string "clangd --version")) which I personally don=CA=BCt like the look of. Robert --=20