From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Mistakes in commit log messages Date: Thu, 13 Apr 2023 09:47:40 +0200 Message-ID: <87cz48fckj.fsf@gmail.com> References: <835ya5m4p0.fsf@gnu.org> <83v8i4arzt.fsf@gnu.org> <838rezardu.fsf@gnu.org> <319d616d-9230-0a82-331f-0f57488e4c80@gmail.com> <834jpm9s1g.fsf@gnu.org> <83v8i28b3j.fsf@gnu.org> <693285d2-e50b-289d-4f3e-ddd817ddc75b@gmail.com> <48d4dffa-cfa8-7949-3043-a1efa937902d@gmail.com> <838rew5lak.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16129"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , acm@muc.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 13 09:48:46 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmrhF-0003td-Rx for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Apr 2023 09:48:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmrgP-0006eP-Qw; Thu, 13 Apr 2023 03:47:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmrgO-0006eB-9z for emacs-devel@gnu.org; Thu, 13 Apr 2023 03:47:52 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmrgJ-0006YZ-1X; Thu, 13 Apr 2023 03:47:52 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id d9so13352235wrb.11; Thu, 13 Apr 2023 00:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681372064; x=1683964064; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=V1PjtGp1m95QUlahhec1bM4jzDWqdZS7L3qHnqKeWbA=; b=JXAGn7lrq7XyybfruDRjr9k6O6NLTlhU3sp7zE4T+pX+On28vUDXc4M0xbhibJZlHC ktqRKleVTOnFHRmSTjo0TW87JdKWeZiss3YxpWT3Bd1jkRxu1EF5sMF3ROKlHwfFrbWu npeFF8Dt490VxWlMAQuNGmWDdqkZ6Srh5pyD7FpL43opKG3DGYn/kTuC/C/kBnUf/Fg9 SC0rMO9zWdzuj2ai1lhQDWCHJ1hl4V58TqCDPU6RX9pFspc8k/cTZ3OT4/jRGPn6+TO5 GElBuGrSdEhanZwpPfpZLTJapDTo9t+XxUQN9B2F73aBwE2NFiKCghnbyO2zw29uEMj+ f2GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681372064; x=1683964064; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V1PjtGp1m95QUlahhec1bM4jzDWqdZS7L3qHnqKeWbA=; b=OWfPFpsTCGFoh4TyoiR3iu2KtdE+H3iHTcDCtcda0WNEdL05fgDa8gCS+3CTTeEDIE RBXtetoMJoFmI2c/O3H65Kb6Hk8xCH0+pSAoWAHOxWYKld6pzNxAdelXne5c7cBnpmVX EC6d+KSk8/EIbVaD/VZrXpWJ6TfOsG9S3hl4pUT26UaC1+4cL+8mGvN7TbZh3/Ow0n57 +EP+Lgpe3AW9WIKLtE1u3bqvc797DqrtJFjk8GkChvDGASLR/dITFQvJHpqfqMz58uQQ VZOZwySe4Cj/346nPRRZKZbs6m0TTprbTTX+PxPu75i7RskdAVhE01tXCnA31b2Fuzvw ftnA== X-Gm-Message-State: AAQBX9eEIsIYMEdJ9cIF7Uz/ghIbtR0JNuri3IUrIzJ9k/GZHgmqfTZt NadHXVFGqo1ansT1wBykRtp0j+0jhzA= X-Google-Smtp-Source: AKy350YI/i3Uz9fhJ6URyJiHBhrmZ+/CLc0eXtyiqBjM1KLlP1Hy4/NIt6IPZ2dplHMGN/PlWt8hPg== X-Received: by 2002:a05:6000:1374:b0:2f2:e0e9:41d6 with SMTP id q20-20020a056000137400b002f2e0e941d6mr832306wrz.28.1681372063878; Thu, 13 Apr 2023 00:47:43 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id k1-20020a056000004100b002f5925c7cabsm662395wrx.75.2023.04.13.00.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 00:47:43 -0700 (PDT) In-Reply-To: <838rew5lak.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Apr 2023 09:49:23 +0300") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=rpluim@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305284 Archived-At: >>>>> On Thu, 13 Apr 2023 09:49:23 +0300, Eli Zaretskii said: Eli> What about the opposite: a file is mentioned in the diff, but not = in Eli> the commit message? Or maybe that is allowed, and we shouldn't bl= ock Eli> it? >From CONTRIBUTE: - There is no need to mention files such as NEWS and MAINTAINERS, or to indicate regeneration of files such as 'lib/gnulib.mk', in the ChangeLog entry. "There is no need" means you don't have to, but you can if you want to. I=CA=BCll admit I tend to the prescriptive side of things, and think all changed files should be mentioned in the commit message. Robert --=20