Re: Dired subdirectories & the ls option time-style with the %R sequence

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Wed, 24 May 2023 13:07:12 +0200, Gautier Ponsinet <gautier@gautierponsinet.xyz> said:

    Gautier> Hello everyone,
    Gautier> I use dired with the variable `dired-listing-switches' containing the
    Gautier> --time-style option of ls (from the GNU coreutils), itself containing
    Gautier> the %R sequence. Precisely, I have:

    Gautier> (setq dired-listing-switches "-l -Fhv --group-directories-first \"--time-style=+%F %a %R\" ")

    Gautier> in my init.el file.

    Gautier> I have adapted the variable `directory-listing-before-filename-regexp'
    Gautier> accordingly and everything works fine, except when I insert a
    Gautier> subdirectory in dired using `dired-maybe-insert-subdir'. It seems that
    Gautier> the "%R" in the time-style option is interpreted as a -R option in
    Gautier> dired-insert-subdir and is removed (there is a (string-replace "R" ""
    Gautier> switches) somewhere in the function `dired-insert-subdir'). As a result,
    Gautier> the expected time is not printed and only a "%" appears, so my regexp
    Gautier> does not work and dired is confused.

    Gautier> Of course, I can also replace the %R by %H:%M in my config, which I do,
    Gautier> and I don't have this problem. Nevertheless, the bug seems there. It
    Gautier> took me some time to understand the problem, and I guess other people
    Gautier> might encounter the same problem.

    Gautier> Maybe `dired-insert-subdir' could search for "R" but exclude "%R"?

Something like the following (untested) patch?

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index fc3f6f4f04d..dc558e13ac8 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -3142,7 +3142,7 @@ dired-insert-subdir
     (and (not switches) cons (setq switches (cdr cons)))
     (dired-insert-subdir-validate dirname switches)
     ;; case-fold-search is nil now, so we can test for capital `R':
-    (if (setq switches-have-R (and switches (string-match-p "R" switches)))
+    (if (setq switches-have-R (and switches (string-match-p "[^%]R" switches)))
 	;; avoid duplicated subdirs
 	(setq mark-alist (dired-kill-tree dirname t)))
     (if elt

Robert
--