From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New Package: phpinspect.el Date: Tue, 15 Aug 2023 20:28:55 +0000 Message-ID: <87cyzojbi0.fsf@posteo.net> References: <25249bd1-bd1b-5888-b67f-718ffd0ad6ff@hugot.nl> <6c692fd7-24ba-be42-7c73-0cc950561479@hugot.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9709"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Hugo Thunnissen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 15 22:29:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qW0fp-0002GT-WE for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Aug 2023 22:29:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW0f4-0003qV-Cd; Tue, 15 Aug 2023 16:29:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW0f2-0003py-O0 for emacs-devel@gnu.org; Tue, 15 Aug 2023 16:29:04 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW0ez-0007YJ-V2 for emacs-devel@gnu.org; Tue, 15 Aug 2023 16:29:04 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EE843240028 for ; Tue, 15 Aug 2023 22:28:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692131339; bh=/rCOa4Xjofroz8RHOCVVaitnjTrfdgHIsBQpbNTEW3k=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=gdswvhNzoCvqXgP7CplDSnGCFSHH+ziyq8mdMvr9Eao3KtMKF9SDRpssAbD/zbkmq NwETn9rPclBAh5oGHNsp/1JpZSMh/AqIpOWoUtNI9rOhnQI59RyES5ZBIqx0mWdYgN AOP6ffYLH2U2BUzdGjNJc6s982aNaEBFmgpC5YbSs7AFqg4Y86W1S47R8/6ZKRqFdq RE/G3AZDboOyGflcR7fiwGot2qlrPgsaHEYZrClPHGvbnm4iyS8FvCj9qNsx6rQZMW MzRlsB0hkoAfgiyT4IDiet2dpYG2h3UGSdeGOvpB62LgwjJI7Dcy3LBjNx12rGQCBv K6MDA4mIf8+lw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RQNCD3czqz9rxF; Tue, 15 Aug 2023 22:28:56 +0200 (CEST) In-Reply-To: <6c692fd7-24ba-be42-7c73-0cc950561479@hugot.nl> (Hugo Thunnissen's message of "Tue, 15 Aug 2023 19:45:38 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308775 Archived-At: Hugo Thunnissen writes: > On 8/12/23 06:56, Stefan Monnier wrote: >>> I would like to propose my package, phpinspect.el, to be added to GNU E= lpa. >> Done. >> >> AFAICT the code has currently some significant problems in terms of >> dependencies which make its compilation fail because variables are used >> by macros during compilation when the var has not yet been defined, or >> macros are used before they're defined, etc... >> >> The patch below seems to make the compilation go through (and fixes >> various warnings), but there are a lot of compilation warnings left >> which you might want to check. It also includes a few FIXMEs. >> >> >> Stefan >> >> > > And here I was thinking that I had fixed all of the byte compilation > problems.. Turns out it was only working because I byte compiled > everything within the same emacs session. I made some changes and > think things should be in order now. At least, the following shell > script doesn't seem to result in any errors: > > for file in ./*.el; do > =C2=A0=C2=A0=C2=A0 cask emacs -batch -L . --eval '(setq byte-compile-erro= r-on-warn > t)' -f batch-byte-compile "$file" || break > done I am not familiar with Cask, what does this provide over a simple Makefile? > I see some warnings in your log that concern files in the "benchmark" > and "test" directories. These files are not required for the package > to function. Can these be excluded from the ELPA build somehow? I have > seen some projects use a "lisp" directory for their source code, is > that the recommended approach for this? You can add an .elpaignore file to your package root. You can list all files in there that you do not with to have added to a package tarball. The file is passed to GNU tar's -X option (see (info "(tar) exclude")). > Thanks, > > - Hugo