From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: ELPA submission: plz-see Date: Tue, 31 Oct 2023 21:17:39 +0100 Message-ID: <87cywubl7g.fsf@gmail.com> References: <87y1fkbmut.fsf@gmail.com> <83y1fk9vcu.fsf@gnu.org> <87bkcfw5ai.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28757"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 31 21:18:41 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qxvCC-0007MX-UK for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Oct 2023 21:18:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxvBP-000776-Lf; Tue, 31 Oct 2023 16:17:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxvBM-00073Z-0M for emacs-devel@gnu.org; Tue, 31 Oct 2023 16:17:48 -0400 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxvBJ-00035c-AN; Tue, 31 Oct 2023 16:17:47 -0400 Original-Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9bf86b77a2aso864624866b.0; Tue, 31 Oct 2023 13:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698783461; x=1699388261; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lqrct85KOJ2Rsm7J2rqb4XMFYlWL7cS2y8F0+VzCNgA=; b=ZWi3/ridFcl88/YwqOfknvaO8d3jSrH6xgHI2k2WNDqh/MnjYT06CsNJOwDu9ZkUsi 6in0ohcF0UEpbk3jACwpn7RD+mHgbLuundCsabrbzgSfm3JqI6oq6xgZ7KS7fsD7hI7n w9lSrXeytn/XBU1DZzfWyIw0rXB9UW1Vwc2IHOQqTLqUXYCX8I86eeN1AAt7lMV+KE2e L7vnRBz+4sHOoJA/lAWE8W6v4jU2n6GzyUvekIDO6w/yuyoDUsKR3LSe5S1zskTSW9Oy hhMQdJJAvHeV86Z5PGiySfEzWFk/qe2e8g+wPqK2QU5tc6uz6t1BLVqRaq4hpBsZ0cup lPDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698783461; x=1699388261; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lqrct85KOJ2Rsm7J2rqb4XMFYlWL7cS2y8F0+VzCNgA=; b=V16oy1RVWEdsOv2x77aJYZWq8i3daKQGCAcSxsLTqZDyAiMWdz48xpnT5U+HOnVpfc 4CbQYt+yfezNnw8yCqIDTdLvCiFKSXBgG/UJUBhoeX+c9Nbm3EN1T/z1iytsE6Hejo4Y zlBNYzMYhq43x2gyoffiheR+M7LzUogzFxABmPFNqRVr40ImZABB4PWdMSMlm22WrMiI am8qz3cNbLKdxqR6sQZrhmNX7kBgmntFIt3B04WgpotGwd45p/AYyakF/YKIYgq4fdRe 5C6Koq05K4BiVhRxWfBXMk04X6CThzHpn9zcCJY2TngRYup9aJXHHDgUp+lkVHL/2k5G 1FFg== X-Gm-Message-State: AOJu0YyXAJlUFkKRV3H4JGej0iXDx0+jZ76doFmb7Dg+kUGV4eTEIoLS Q1UKqlKFygocPxvHb3a72XEY/jnQ1ec= X-Google-Smtp-Source: AGHT+IGix2GTprmbt0BMKzb+aVghKZtL0AK6G1xKHmHfxCD4WXLnCaq1LfHraiCOjNnj9LZqU6vn7w== X-Received: by 2002:a17:907:6ea9:b0:9c5:45f8:c529 with SMTP id sh41-20020a1709076ea900b009c545f8c529mr405395ejc.20.1698783461410; Tue, 31 Oct 2023 13:17:41 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ace:5100::1448]) by smtp.gmail.com with ESMTPSA id g25-20020a1709064e5900b009a5f1d15642sm1478778ejw.158.2023.10.31.13.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 13:17:40 -0700 (PDT) In-Reply-To: <87bkcfw5ai.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 31 Oct 2023 08:43:33 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312025 Archived-At: Thanks for the comments! On Tue, 31 Oct 2023 at 08:43, Philip Kaludercic wrote: > +(eval-when-compile (require 'cl-lib)) > (require 'json) By the way, the latter is kind of a non-essential require, would you rather write this near line 88? (defcustom plz-see-content-type-alist `(... ("\\`application/json" . ,(lambda () (require 'json) (declare-function 'json-pretty-print-buffer "json.el") (json-pretty-print-buffer) (js-json-mode))) ...)) > I agree, from what I see this is just an implementation detail. Plz is > a peculiar enough name as it is, it shouldn't be inherited by packages > that depend on it. Or is there any reason why the package couldn't also > use url.el? The packages is really closely tied to plz's API, which by the way is a very nice one.