From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam James <sam@gentoo.org> Newsgroups: gmane.emacs.devel,gmane.comp.sysutils.autoconf.patches Subject: Re: [PATCH] Add quotes in AS_IF test for gid_t Date: Thu, 08 Feb 2024 05:01:56 +0000 Organization: Gentoo Message-ID: <87cyt7v987.fsf@gentoo.org> References: <20240207033334.1489580-1-sam@gentoo.org> <4e0c6b19-07bc-fbc5-4e4c-df2b088db4cb@draconx.ca> <02136282-9cb4-4c62-8f98-38803c51f618@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21080"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.8; emacs 30.0.50 Cc: Nick Bowler <nbowler@draconx.ca>, Sam James <sam@gentoo.org>, autoconf-patches@gnu.org, Emacs development discussions <emacs-devel@gnu.org> To: Paul Eggert <eggert@cs.ucla.edu> Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 06:03:30 2024 Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org> Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>) id 1rXwZN-0005J4-Qv for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 06:03:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <emacs-devel-bounces@gnu.org>) id 1rXwZC-0000Be-UV; Thu, 08 Feb 2024 00:03:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <sam@gentoo.org>) id 1rXwZ9-0000Am-Ji; Thu, 08 Feb 2024 00:03:15 -0500 Original-Received: from dev.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <sam@gentoo.org>) id 1rXwZ7-0006RM-1K; Thu, 08 Feb 2024 00:03:14 -0500 In-reply-to: <02136282-9cb4-4c62-8f98-38803c51f618@cs.ucla.edu> Received-SPF: pass client-ip=2001:470:ea4a:1:5054:ff:fec7:86e4; envelope-from=sam@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." <emacs-devel.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>, <mailto:emacs-devel-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/emacs-devel> List-Post: <mailto:emacs-devel@gnu.org> List-Help: <mailto:emacs-devel-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>, <mailto:emacs-devel-request@gnu.org?subject=subscribe> Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316012 gmane.comp.sysutils.autoconf.patches:9054 Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/316012> Paul Eggert <eggert@cs.ucla.edu> writes: > On 2/6/24 20:37, Nick Bowler wrote: >> On 2024-02-06 22:33, Sam James wrote: >>> Noticed when building Emacs: >>> ``` >>> * checking type of array argument to getgroups... ./configure: 42782: test: =: unexpected operator >>> ``` > >> Oh look, I see this line in emacs-29.2/configure.ac: >> AC_DEFUN([AC_TYPE_UID_T]) >> This is the actual cause of the problem, because AC_TYPE_UID_T is >> the >> part of Autoconf that would have assigned this variable. Since Emacs >> has deleted its definition, it has therefore broken other Autoconf >> macros (like AC_TYPE_GETGROUPS) which depend on it. > > Thanks for reporting this. I installed the attached patch into Emacs master. > > The now-fixed bug in Emacs's generated 'configure' script should be > harmless on all platforms I know about, as AC_TYPE_GETGROUPS should go > ahead and do the right thing anyway. Thank you Paul! > > PS. There is a case for quoting all uses of ac_cv_* variables, as > their values may be corrupted in the cache. This is my usual style > elsewhere and perhaps Autoconf should adopt it. Of course if we'd done > that we would likely never have spotted this harmless error in Emacs > configure.ac.... Yeah, I had the same thought process and feel a bit torn. thanks, sam