read-string-from-buffer: Removing text properties

read-string-from-buffer: Removing text properties

[Thanos Apollo]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]


Hello emacs-devel,

I'm trying to use read-string-from-buffer & I have found some
interesting interactions that it has with text properties.

Example:

(read-string-from-buffer "Prompt" (propertize "warning face" 'face 'warning))

;; Returns: #("warning face" 0 12 (face warning))

Should it not read-string-from-buffer behave similarly to read-string,
and just return a string?

If this is not intentional, just applying substring-no-properties should
resolve this.

Example:

(defun read-string-from-buffer (prompt string)
  "Switch to a new buffer to edit STRING in a recursive edit.

Also see `string-edit'."
  (string-edit prompt string
   (lambda (edited)
     (setq string (substring-no-properties edited))
     (exit-recursive-edit))
   :abort-callback (lambda ()
                     (exit-recursive-edit)
                     (error "Aborted edit")))
  (recursive-edit)
  string)



Thank you,

-- 

Thanos Apollo
 
https://thanosapollo.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

Re: read-string-from-buffer: Removing text properties

[Eli Zaretskii]

> From: Thanos Apollo <public@thanosapollo.org>
> Date: Fri, 08 Mar 2024 13:58:54 +0200
> 
> I'm trying to use read-string-from-buffer & I have found some
> interesting interactions that it has with text properties.
> 
> Example:
> 
> (read-string-from-buffer "Prompt" (propertize "warning face" 'face 'warning))
> 
> ;; Returns: #("warning face" 0 12 (face warning))
> 
> Should it not read-string-from-buffer behave similarly to read-string,
> and just return a string?

What read-string does is AFAIU controlled by the variable
minibuffer-allow-text-properties, so it doesn't always discard the
text properties.