From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 1aa83da46d1 2/2: ; * etc/NEWS: Rename read-process-output-fast here also. Date: Tue, 11 Jun 2024 14:35:32 +0200 Message-ID: <87cyonbqsr.fsf@gmail.com> References: <171808806905.4080.7963946550063771118@vcs2.savannah.gnu.org> <20240611064113.5E651C1FB57@vcs2.savannah.gnu.org> <87tthzg9qi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Po Lu To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 11 14:36:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH0je-0008Ra-HI for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jun 2024 14:36:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sH0iw-0003Kp-V5; Tue, 11 Jun 2024 08:35:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH0iv-0003Kg-LT for emacs-devel@gnu.org; Tue, 11 Jun 2024 08:35:37 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sH0iu-0001UR-2y for emacs-devel@gnu.org; Tue, 11 Jun 2024 08:35:37 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-35f2266edd8so816524f8f.0 for ; Tue, 11 Jun 2024 05:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718109334; x=1718714134; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=y9gBl0eqlJOBlfDlZ7sVllGUNw5gbvGBrfAIvxQ/wmA=; b=D/IQtFkC25nr0zVIP7GMzNi1X+jkcc+aHNS3xcl1sRZvsmN8qtewuPU/rErEv42OVn klQTy+MDxoAImzvv+wtMRyzU1blJkTXp2cB/OaGk3ynINLOPoPiVdlAi32Vw4BzcekM9 6ZoLv4/A9dk5Dbt2poWwiTdjFJ5gZqmrHS/YVCySQ75NDr9FYdvXzHQ/I9bsjCzUFmO3 r7MhrtGC21cNS9iVYlP0Ym9xGCyHLwfFQsalj5h+eBkOwV30mBzMoTluM53J+ST0YKea 6Xjf9MpsBdKTtqt3ObeVSlutKfQPRrfJvctk+yvg0UT6UpqHLC9gg69KnwH6Hwe1PUfl z8kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718109334; x=1718714134; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y9gBl0eqlJOBlfDlZ7sVllGUNw5gbvGBrfAIvxQ/wmA=; b=J31gEZEpb2eSQTmKoCnMBPskCn5dFtZF69XUUQ8henwtJ/U5I+ZBrH5zDpzX2KFP/r cixfkO8x3c+sjmqdIJbfaiaad58Nj2fVF69YUY2psz2615Ua3T0kn82pxKYepJZG7kVM HC9MNW5V+AlPGnilEW2CXMHkCCfsHEM+9EfZJtzhFf18XI/NVtQi+uvh5UOSkXsa9ka3 E2u8OS44LYoNKen4XHJ6O6t+RF6Vp712WelZace6xqV7vc6POitp+/PVhvd5ZydAAF8p riV+4Z7vn/CipccmgekRVA06FtqIUBpLRe2gc1Dkittu59yjAZbhs6nhnTP6j83pxPH3 7FSw== X-Gm-Message-State: AOJu0YyvC3UDDPUP1Wg1MB3II+S547FBjDV4H7vQEWKMrUT6VOXKCIzc 0mbg2o8BaR4qfLJTCPG64XMauGs6+j0VIULP8Taf1KLttE7+YYx/shx+3A== X-Google-Smtp-Source: AGHT+IFV6/+XkQmR2rt19ulKtF4uJfjNAqd5KUnhQkc5g1Uj2XYDwLf0YlYUy2i6zc0yLwK5hjGGVg== X-Received: by 2002:adf:fd0a:0:b0:35f:215a:9a68 with SMTP id ffacd0b85a97d-35f215a9ac9mr5320450f8f.1.1718109333731; Tue, 11 Jun 2024 05:35:33 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f271ead7bsm4380855f8f.20.2024.06.11.05.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 05:35:33 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Tue, 11 Jun 2024 15:28:44 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319971 Archived-At: >>>>> On Tue, 11 Jun 2024 15:28:44 +0300, Dmitry Gutov s= aid: Dmitry> On 11/06/2024 11:32, Robert Pluim wrote: >> Po Lu> -To undo the change, set 'read-process-output-fast' to nil. >> Po Lu> +To undo the change, set 'fast-read-process-output' to nil. >> I realise we=CA=BCve renamed this one already, but would it not make >> more >> sense for the variable to be called something starting with >> 'process-', such as 'process-fast-read-output'? That=CA=BCs in line = with >> other variables affecting the processes process data, such as >> `process-adaptive-read-buffering'. Dmitry> The idea behind this name was to match one specific C function = (which Dmitry> might be familiar to many who read Emacs's code), but I don't h= ave a Dmitry> strong opinion either way. process-read-output-fast, maybe? If I was being pedantic [1] I=CA=BCd say it should be 'process-read-output-simple', the 'fast' bit is just the side effect ;-) More seriously: the variable name should describe the semantics. What underlying function is used as a result is not relevant to users of the variable. Dmitry> Also note that both previous names have been already mentioned = in Dmitry> bug#71452 comments, so I suppose the new one should be mentione= d too, Dmitry> in order to avoid keeping an outdated source on that subject. Investigation for me normally goes 'search bug# in commit log' -> git show =20 so it doesn=CA=BCt really matter if the bug comments match the code. Robert Footnotes: [1] Moi, pedantic? Never. --=20