From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS symbols Date: Fri, 28 Jun 2024 13:54:16 +0200 Message-ID: <87cyo1wadz.fsf@gmail.com> References: <87r0chwnzx.fsf@gmail.com> <87ikxtwljl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13651"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 28 13:55:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNACC-0003Iu-Hz for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jun 2024 13:55:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNABS-00071m-9V; Fri, 28 Jun 2024 07:54:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNABP-00071M-DT for emacs-devel@gnu.org; Fri, 28 Jun 2024 07:54:27 -0400 Original-Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNABN-0000vS-23 for emacs-devel@gnu.org; Fri, 28 Jun 2024 07:54:26 -0400 Original-Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2ec595d0acbso5891011fa.1 for ; Fri, 28 Jun 2024 04:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719575663; x=1720180463; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q+7Tgzigzp6/lCZvnnaHtq/QJRoT6L+HEX4P6lhYjJ4=; b=TICVpNFY7RXQlYU5JS+6VSq2bYV1z3Q+H2BKtp1TBqZaFxWb0/iWNeA/jrl8us0ZrZ Cf/hKs0UtbFd2rXXPAvzK3heK1C2E2dldBOgSvq4LBkGy6S6e3caiscb7vWzXxoJtw/W B2p3sAG0RAaCX4kC6vOrexBxzcgz6Z6M2GScOznNy9EMFWqAhZ2oB+6FRIkK6X0QCACy IQWkVzhYJWbPp0yWmBlH4k7Y4Id0YwCS8dCXjalYmkYp/t0hubqnFFCGgVP+82io+uuO L6vCCttQZpKhONwFz4x/1RSi4QVzO1i/ufERR2H3xAMW7987bNisDd/WaHdngVy9kiHC NHZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719575663; x=1720180463; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q+7Tgzigzp6/lCZvnnaHtq/QJRoT6L+HEX4P6lhYjJ4=; b=IyWsyryJv2kz/i1KJrOc5z5+A7hzXlvxnlHJwXEmrm9MqxBrDcLMxMQS+gKrf6getS m9ZrYCygoMPTcp/6T5c9KG7MXosq1sVNNnya5ClPZwy/A7DbRMPnBUo1wdPLO5Dzd+x1 nteVQBL5vPf5no4wXAwJFp/UiwlDqNT3eyq7Qi60PEORtN5iA6f7C592Wifjhl4kCfdK N+YCTfY6KoG+RFyT45W3Vjbk3wxoGf4y/v33HirfpTJRC1qCDu1aON+jufD2cyLA/TR8 /4XD4Pyu3rg3kyi1Uyhge1K0uwSwuCVH4aJC7/MEWG2lErzbBj/jMUkm/58ZKhH2WFUW Q33w== X-Gm-Message-State: AOJu0YxmhypoFy4goBa300bs8/lyoBg1FOuIbjU+JUfGRrlPtXKCabiw EYF3aQIDVDR6hYQEdZTo4nkC+dU0/8SMt5tvFVN+8QUmMn4b1ZgmtFUdwA== X-Google-Smtp-Source: AGHT+IE7Yfa9VwvcjwN7sGMYDKDf64ZI0f2sTlP+cL8Meu6nZSkL3igfUJ4MPzePxuMqRkp90uXbyQ== X-Received: by 2002:a2e:9985:0:b0:2ec:5811:edd4 with SMTP id 38308e7fff4ca-2ec5b31d1c1mr120836821fa.31.1719575657168; Fri, 28 Jun 2024 04:54:17 -0700 (PDT) Original-Received: from caladan (dial-187254.pool.broadband44.net. [212.46.187.254]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256af55e61sm32236135e9.20.2024.06.28.04.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 04:54:16 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Fri, 28 Jun 2024 11:19:21 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=eller.helmut@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320810 Archived-At: On Fri, Jun 28 2024, Gerd M=C3=B6llmann wrote: > Gerd M=C3=B6llmann writes: > >> Forgot something. While looking at the scanner, I wondered if we could >> remove the is_mps check from fix_lisp_obj now that we have the dump >> in MPS... > > Let's find out, pushed. Works for me :-) I think this uncovered a bug. Now this emacs -Q -eval '(progn (view-hello-file) (forward-line 7) (dotimes (_ 5) (redisplay) (igc--collect) (forward-line)))' -f kill-emacs causes a SIGSEGV in fix_font, case FONT_OBJECT_MAX: { struct font *f =3D (struct font *)v; const Lisp_Object *type =3D &f->driver->type; IGC_FIX12_OBJ (ss, igc_const_cast (Lisp_Object *, type)); } It turns out that f->driver is the variable xfont_driver and it is actually const and the type field is a builtin symbol. So it looks like we can remove fix_font completely.