From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS: commit limit Date: Tue, 16 Jul 2024 18:48:20 +0200 Message-ID: <87cyndth9n.fsf@gmail.com> References: <87ed85xj67.fsf@gmail.com> <8734olxcdj.fsf@gmail.com> <87bk2xweng.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36115"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , Ihor Radchenko , Eli Zaretskii , emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 18:48:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTlM7-00097t-Qq for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 18:48:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTlLn-0007yW-W8; Tue, 16 Jul 2024 12:48:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTlLm-0007of-3H for emacs-devel@gnu.org; Tue, 16 Jul 2024 12:48:26 -0400 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTlLk-0002dj-CI; Tue, 16 Jul 2024 12:48:25 -0400 Original-Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-427ad8bd88eso18175905e9.2; Tue, 16 Jul 2024 09:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721148501; x=1721753301; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VxFrKqxVllTugOMYM2gH85BJ/YxmkDYMfoZUwS2U/Hc=; b=LKHree0EqGRVzURtZp5cw/vwwZIKTuOYhPLqees/ZAtoVlnQH6kyWqgHPj9BNnJQeS 5e62Aw9srQC+DAtOqfTFCI0crqVyCXh/DJ9y5zK3Gzn5RfbXklbt8BLXtPiJewDkcrTK 8yS/boahFMbptc8B/ejqeUl9EjlStH0JYNwZXdUg5nbHKLM/q2ZgvnruBRgRNMyzw5/M 2dUoj4Ok5lpBNGfMA7PqX8cvM26Hq6tejPquJ7NTYYNBMaxhoz0y9vibDWQJIxuKfcM9 6CCj7y3UPUe9OaKvhAIJ6ZUOkg2XC06csWgpgz+n0c2Y/cPjiBcXK/6bqoNwmiEuSQRN 0SeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721148501; x=1721753301; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VxFrKqxVllTugOMYM2gH85BJ/YxmkDYMfoZUwS2U/Hc=; b=SAKWREKRTJbJbjMYm+t57MjH5rQcpAx0KGlBhVMD3R79agiJWw+7n47v3eUHGOxQYb 88pPzcqjtcTPGPm5yCIjGz6ShNDoY5qG64OmP/HYV6rNRpzkJjowNXjzuO4wI3y6vVry 0hyRFxAD7DUnfjkSJllTNN2c0VjuDQDtW3cZeaT93wbsNjfAXNiLMAOZ57XgwFyhaVP7 EahWeleFxq9Zh5PKS49eaDmoqD0KGag2DBXfx89F15rVE4BzmF8/Y/JJP1CAkTTDHrC2 KjVwS3SNvQLq6FPMC6nK4+xTaT4nMKecySoUMsmRC4clzgCRfhTnRwNM1l8w8IF2emac z3xg== X-Forwarded-Encrypted: i=1; AJvYcCXYpnGu3d0yny4HhgLr0hVOie1BlvkzDjbE+zxtEJdJitU/0OV80Qo1sSpqZsIvejayeG6ohyAeEB2DRbr5k1MLw+PhddoWrhA1mK/Zo1Bz6sA= X-Gm-Message-State: AOJu0YzonnRiPcZzrE12k5E9GVCyVAZU9/5cL9y4F1F+bEuEmlG7ICWq EotpXTq2inKNpgqPFI+XBrO5fH7A82lfyGcVFPWeokgQTtgqrl0eUvuCVg== X-Google-Smtp-Source: AGHT+IGr5RXXQo4wccGfwNw/8acOfIaQ3huttGyvLrUvw+8fGRKdZDnMmLvWGNofKUncd3KhJGGFxQ== X-Received: by 2002:a05:600c:1989:b0:426:59ec:17a9 with SMTP id 5b1f17b1804b1-427ba66cc9bmr18572555e9.22.1721148501152; Tue, 16 Jul 2024 09:48:21 -0700 (PDT) Original-Received: from caladan (dialin-234199.rol.raiffeisen.net. [195.254.234.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e8387fsm133586995e9.20.2024.07.16.09.48.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 09:48:20 -0700 (PDT) In-Reply-To: (Pip Cet's message of "Tue, 16 Jul 2024 16:32:50 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=eller.helmut@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321724 Archived-At: On Tue, Jul 16 2024, Pip Cet wrote: >> This patch adds a igc--set-commit-limit function. It doesn't fix the >> problem with the assertion. People who use the hot MPS build will >> probably see a normal memory full error and probably have to quit soon >> after that. The others see the failed assertion and abort immediately. >> So the end result will not be much different. > > I'm not sure about that one. Should we really expose a function we > know to be buggy in the single implementation that people are likely > to use? Because it's the obvious function to tell MPS how much memory it should use. See: https://mailman.ravenbrook.com/pipermail/mps-discussion/2016-May/000192.html > I don't understand why you made it invalid to set the commit > limit to SIZE_MAX, because that is a valid commit limit, and what the > MPS explicitly suggests you should set the commit limit to. Because (igc--set-commit-limit nil) is clearer from a Lisp perspective. >> The other two patches are minor cleanups. > > Those look good to me Sorry, again, for taking so long with the > current patch set, which touches this same code (and indeed does the > same thing for igc_assert()...) > > BTW, are you still running performance tests? No.