From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 f050b9c5033: Fix Tramp IPv6 handling in tests Date: Mon, 05 Aug 2024 20:21:30 +0200 Message-ID: <87cymmomol.fsf@gmx.de> References: <172163502862.25672.12565431460737995012@vcs2.savannah.gnu.org> <20240722075709.1C23CC41F06@vcs2.savannah.gnu.org> <87mslqoql8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12357"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Madhu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 05 20:22:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sb2Ly-00032S-Mg for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Aug 2024 20:22:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sb2L4-0005Ih-W4; Mon, 05 Aug 2024 14:21:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sb2Kx-0004yT-Mb for emacs-devel@gnu.org; Mon, 05 Aug 2024 14:21:40 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sb2Kv-0000F5-U5 for emacs-devel@gnu.org; Mon, 05 Aug 2024 14:21:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1722882092; x=1723486892; i=michael.albinus@gmx.de; bh=cRronTduNyopsfKmpZjGiDDi8M/lIPPMhQmYh8658z8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Ar5GA9NGU0iq5zY0Bi9Xf2vD/Tl8Gfkm2Vh+qKKQA/GBNMh9N4ek3jihCg22hQwL +lKam4Btsx31kiP0N2muG3yZkHq4W5vN4ksqH2OIY17uL6POvJEUUf8BttiQtTpcb rBFnTYszfO8byakFIOmM9T6tIG2l2L34OdUhUbTFiSK9ltdxWTPZrTg4mHYBuYJ2Q R4HMSDn5Mj7zfaWfYFoU8J81UQysn4dUxNf4krbj1LogYEvZoCQkmSMIPs4/w4hjG 2eLvNC/84mkKnSoThjnX/ZymUZHt55KvDun65f8CGZr5+mm2PVRO+3R/gC4tmmz0I /Xv2E/n0E8s+A7/zhw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6Ue3-1sYXMj0RqL-00F3UZ; Mon, 05 Aug 2024 20:21:32 +0200 In-Reply-To: <87mslqoql8.fsf@gmx.de> (Michael Albinus's message of "Mon, 05 Aug 2024 18:57:07 +0200") X-Provags-ID: V03:K1:7u4UXZz/MsQY4inbwQFaZYcXr5WhMk0EpNKH4YzafJfI2R+QOQP L1mYoGWiDED/s8rAlWb7gxT+bXClUjVbZjs4IKnh2lIGesYY+Un6N3u934eBMJH2xq00yKN 0ljOT1WOFC2QK5kbRNUMDj0sm+wFnSNVUEtnHfllxlZv66l6znj5jRrk+eLzte5FW+ozyFR G7RbFStUug/r2BoeemEKQ== UI-OutboundReport: notjunk:1;M01:P0:+MIJiN0kPCY=;2F/qWk++ZIrv8Ea9U4XcAQVCps/ 7GBElleibcaSyhRUE1268/zJfEmzjwG88ZwhNvW7uLBJA//YhgLh4Aku00s62GqFbYuyQjDzb xBNiFxHz4qbw+xaJZJdu1lwLi/P2f2upszzupkgHnWILHI3UOmlPwpKO0l+Ial9OZDti+jjEE UmiaRYzi1cz5azKrsFB4zSMOSZLpzrjvTvVLxAZo1Az+KL+QTtLeyetcYGM/KyO7gCnFVpFel iC9EaYrUf+YrASITlMIsdo9FgLKKxhl6d3XwqFq6MaMtXT8214hh0YSqt3gatWYrFjEfZsbxY HAifyI1WGbwClnHAxFH4rkzPFcuItyMLXwK85mQsy5OmBlRo6ASPjJchScJMWY76lOiZsmVAm 4re9UPQzFU6BENjpbn+g4E4h4BHSSEVGEsMhh6P2ri/1FtoAfZZrmy+fCcDLQfqyQ1g4Nvyk6 dxE9OUN3B1mFRL4Te4ET0pfw4zOCCuJg1SVwMftRcpUJ00N27PSmZbIfLKS0nofQoC6gwa3zs felXrGQeRI7moecDZVqFlAJZngObJwfysNawGTkIjzN25Cv34zqoePyEzcmhCantv/0XfWFQs 1YJv8uxMcgGc6WjYvEO9PPUt7uzVKSf6B9ePh+SKueSzLVwLJWss3vdkXLcOBGDB+e7Ww/9fr CKfMjTvP71p0ILmG8jJXUEJNjMkwCy8GZIwUm4b59/FyqFemUNQ5/PnDUYX2hEmBWXk9F9A/U fSFXOmnoxfKAbL5jGqp5FsSFy7HA4LLCNI3R8dE4VCFiIdjASCqy+LNBcVw2NbOuy+bBu+kJ Received-SPF: pass client-ip=212.227.15.19; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322406 Archived-At: Michael Albinus writes: Hi Madhu, >>> ;;; Integration of shortdoc.el: >>> >>> (with-eval-after-load 'shortdoc >>> - (dolist (elem '((file-remote-p >>> + (dolist (elem `((file-remote-p >>> :eval (file-remote-p "/ssh:user@host:/tmp/foo") >>> - :eval (file-remote-p "/ssh:user@host:/tmp/foo" 'method)) >>> + :eval (file-remote-p "/ssh:user@host:/tmp/foo" 'method) >>> + :eval (file-remote-p "/ssh:user@[::1]#1234:/tmp/foo" 'host) >>> + ;; We don't want to see the text properties. >>> + :no-eval (file-remote-p "/sudo::/tmp/foo" 'user) >>> + :result ,(substring-no-properties >>> + (file-remote-p "/sudo::/tmp/foo" 'user))) >> >> just a caveat that substring-no-properties can end up being called on >> nil here. I agree it is unlikely, but I managed to trigger it with the >> `swiper' package, where an unconditional (require 'tramp) in the midst >> of code kept failing. > > In that case (file-remote-p returns nil) the whole block doesn't make > sense. How did they manage to manipulate Tramp this way? Setting > tramp-mode to nil? Manipulating file-name-handler-alist? I've added a sanity check. Pushed to the emacs-30 branch. Best regards, Michael.