* Re: emacs-30 1463434907e: ; Eliminate C++ comments and typo
[not found] ` <20240817140133.2E323C2BC70@vcs2.savannah.gnu.org>
@ 2024-08-17 16:37 ` Eli Zaretskii
2024-08-17 23:48 ` Po Lu
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2024-08-17 16:37 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
> Date: Sat, 17 Aug 2024 10:01:33 -0400 (EDT)
> From: Po Lu <luangruo@yahoo.com>
>
> branch: emacs-30
> commit 1463434907eeccd077f5d3c00309d1e75c7d63f4
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
> ; Eliminate C++ comments and typo
>
> * lib-src/etags.c (Rust_entries): Eliminate C++ comments and
> typo.
>
> Date: Sat, 17 Aug 2024 10:04:12 -0400 (EDT)
> From: Po Lu <luangruo@yahoo.com>
>
> branch: emacs-30
> commit 5397808e5bc314ca7ff6a707c153e59cf141008b
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
> ; Eliminate more C++ comments
>
> * lib-src/movemail.c:
>
> * nt/preprep.c (main):
>
> * src/unexw32.c (unexec): Convert C++-style comments to C.
Why on earth are these cleanups being done on the release branch?
Cleanups are _never_ done there! Please don't do anything like that
on the release branch, certainly not without asking first!!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: emacs-30 1463434907e: ; Eliminate C++ comments and typo
2024-08-17 16:37 ` emacs-30 1463434907e: ; Eliminate C++ comments and typo Eli Zaretskii
@ 2024-08-17 23:48 ` Po Lu
2024-08-18 4:45 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Po Lu @ 2024-08-17 23:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sat, 17 Aug 2024 10:01:33 -0400 (EDT)
>> From: Po Lu <luangruo@yahoo.com>
>>
>> branch: emacs-30
>> commit 1463434907eeccd077f5d3c00309d1e75c7d63f4
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>> ; Eliminate C++ comments and typo
>>
>> * lib-src/etags.c (Rust_entries): Eliminate C++ comments and
>> typo.
>>
>> Date: Sat, 17 Aug 2024 10:04:12 -0400 (EDT)
>> From: Po Lu <luangruo@yahoo.com>
>>
>> branch: emacs-30
>> commit 5397808e5bc314ca7ff6a707c153e59cf141008b
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>> ; Eliminate more C++ comments
>>
>> * lib-src/movemail.c:
>>
>> * nt/preprep.c (main):
>>
>> * src/unexw32.c (unexec): Convert C++-style comments to C.
>
> Why on earth are these cleanups being done on the release branch?
> Cleanups are _never_ done there! Please don't do anything like that
> on the release branch, certainly not without asking first!!
These aren't code changes, only doc changes.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: emacs-30 1463434907e: ; Eliminate C++ comments and typo
2024-08-17 23:48 ` Po Lu
@ 2024-08-18 4:45 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2024-08-18 4:45 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Sun, 18 Aug 2024 07:48:16 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> ; Eliminate more C++ comments
> >>
> >> * lib-src/movemail.c:
> >>
> >> * nt/preprep.c (main):
> >>
> >> * src/unexw32.c (unexec): Convert C++-style comments to C.
> >
> > Why on earth are these cleanups being done on the release branch?
> > Cleanups are _never_ done there! Please don't do anything like that
> > on the release branch, certainly not without asking first!!
>
> These aren't code changes, only doc changes.
Comment style has nothing to do with documentation. More importantly,
these are not improvements or bugfixes in any sense of those words
that is applicable to a release branch. Please don't do anything like
that on the release branch in the future, certainly not without asking.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-18 4:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <172390329286.25071.13652148232082952035@vcs2.savannah.gnu.org>
[not found] ` <20240817140133.2E323C2BC70@vcs2.savannah.gnu.org>
2024-08-17 16:37 ` emacs-30 1463434907e: ; Eliminate C++ comments and typo Eli Zaretskii
2024-08-17 23:48 ` Po Lu
2024-08-18 4:45 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).