From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: progress-bar Date: Tue, 29 Oct 2024 15:24:36 +0000 Message-ID: <87cyjj3paj.fsf@posteo.net> References: <87h68v3q9k.fsf@posteo.net> <2930e7fd-a44a-4ab8-b2c8-809757a6af3a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8451"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mariano Montone Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 29 16:25:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t5o61-00023E-5c for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Oct 2024 16:25:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5o5M-0005SS-Sx; Tue, 29 Oct 2024 11:24:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5o5L-0005Rz-3D for emacs-devel@gnu.org; Tue, 29 Oct 2024 11:24:43 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5o5J-00016Q-5e for emacs-devel@gnu.org; Tue, 29 Oct 2024 11:24:42 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6361A240027 for ; Tue, 29 Oct 2024 16:24:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730215478; bh=WKAEqEb+//I0s+n0lGGngp70XJrosEPuOheHys3cKCg=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=sJBQCgcIfKwRR1rYO4XnMm4PCU96fezFuHksFqfme1HEDLrGtAOiTCgQrn1Jfgyfv Ko9t8biN6Pdop0VKsEHe5xwIDXFKp5EOkEcHY07ok3mncFLAKfm8nnCLgvWZ+VVFPY 4vVWrega7eXHH2ayeX5NfK5/h+3T5mh/bJ1wYcON4nOtjICCXj4ogtyIBXqFSZhpj3 pkxGW3X1/b2tQS2ActXo4GMmT9Whu9PJKW0KUG/yomIZG2AleP/k9LRpXC857p5/8b RFj2CczHtxoYAqEVR7XMkfNF0DJJFjB/+BkTTcVAb51PeX3qdL4Fzb0gJBVRpskO4Q EsdBzARIxw0bg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XdDZY34ymz9rxL; Tue, 29 Oct 2024 16:24:37 +0100 (CET) In-Reply-To: <2930e7fd-a44a-4ab8-b2c8-809757a6af3a@gmail.com> (Mariano Montone's message of "Tue, 29 Oct 2024 12:06:09 -0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324920 Archived-At: Mariano Montone writes: > El 29/10/24 a las 12:03, Philip Kaludercic escribi=C3=B3: >> My main question, which I realised too late when reading the code, is if >> you could rework this to integrate into existing instances of >> `make-progress-reporter', just replacing the UI. It seems like it would >> be more effective and consistent, and avoid hard dependencies of >> programs that want to use `dotimes-with-progress-bar' (or as I renamed >> it `progress-bar-dotimes' to avoid namespace clashes), when >> `dotimes-with-progress-reporter' already exists and is being used. > > Oh. Thanks for the patch! I'll look at it. Just keep in mind that it is not a patch, it is just a convenient way to suggest changes and add comments. > The integration part is in progress-bar-integrations.el. How does it > looks to you? Oh, I missed that. My main issue is that this mixes both the `progress-reporter-do-update' integration with other advice on functions like `package-upgrade-all'. I think having a global minor mode would be the right approach, instead of advising on the top-level. Generally it would be neat if we could find a solution that would avoid the need for advice, but I don't see a clean way to do that right now. Would you be interested in preparing a patch for subr.el that would make progress-reporters more flexible? > =C2=A0=C2=A0=C2=A0 Mariano > --=20 Philip Kaludercic on siskin