From: Philip Kaludercic <philipk@posteo.net>
To: Mariano Montone <marianomontone@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package: progress-bar
Date: Tue, 29 Oct 2024 15:24:36 +0000 [thread overview]
Message-ID: <87cyjj3paj.fsf@posteo.net> (raw)
In-Reply-To: <2930e7fd-a44a-4ab8-b2c8-809757a6af3a@gmail.com> (Mariano Montone's message of "Tue, 29 Oct 2024 12:06:09 -0300")
Mariano Montone <marianomontone@gmail.com> writes:
> El 29/10/24 a las 12:03, Philip Kaludercic escribió:
>> My main question, which I realised too late when reading the code, is if
>> you could rework this to integrate into existing instances of
>> `make-progress-reporter', just replacing the UI. It seems like it would
>> be more effective and consistent, and avoid hard dependencies of
>> programs that want to use `dotimes-with-progress-bar' (or as I renamed
>> it `progress-bar-dotimes' to avoid namespace clashes), when
>> `dotimes-with-progress-reporter' already exists and is being used.
>
> Oh. Thanks for the patch! I'll look at it.
Just keep in mind that it is not a patch, it is just a convenient way to
suggest changes and add comments.
> The integration part is in progress-bar-integrations.el. How does it
> looks to you?
Oh, I missed that. My main issue is that this mixes both the
`progress-reporter-do-update' integration with other advice on functions
like `package-upgrade-all'. I think having a global minor mode would be
the right approach, instead of advising on the top-level.
Generally it would be neat if we could find a solution that would avoid
the need for advice, but I don't see a clean way to do that right now.
Would you be interested in preparing a patch for subr.el that would make
progress-reporters more flexible?
> Mariano
>
--
Philip Kaludercic on siskin
next prev parent reply other threads:[~2024-10-29 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 13:42 [ELPA] New package: progress-bar Mariano Montone
2024-10-29 14:47 ` Mariano Montone
2024-10-29 14:50 ` Mariano Montone
2024-10-29 14:49 ` Eli Zaretskii
2024-10-29 14:53 ` Mariano Montone
2024-10-29 15:03 ` Philip Kaludercic
2024-10-29 15:06 ` Mariano Montone
2024-10-29 15:24 ` Philip Kaludercic [this message]
2024-10-29 15:48 ` Mariano Montone
2024-10-29 16:19 ` Mariano Montone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyjj3paj.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=marianomontone@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).