From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Upstreaming org-element-ast (was: Improving Emacs' iCalendar support) Date: Sun, 05 Jan 2025 13:30:00 +0000 Message-ID: <87cyh1pew7.fsf@localhost> References: <87ed4dss2x.fsf@ohm.mail-host-address-is-not-set> <87mshq9w5c.fsf@ohm.mail-host-address-is-not-set> <86ed31j6zk.fsf@gnu.org> <87ldx9vsnb.fsf@localhost> <868qt8kj6f.fsf@gnu.org> <87ikscx5io.fsf@localhost> <867c8skhy6.fsf@gnu.org> <87frngx4fx.fsf@localhost> <864j3wkczm.fsf@gnu.org> <87cyhg0zjz.fsf@localhost> <87ttamtf7g.fsf@recursewithless.net> <87h66l2isk.fsf@localhost> <87cyh8guci.fsf@recursewithless.net> <87r05mg9ve.fsf@localhost> <87seq290b6.fsf@recursewithless.net> <87msg9qej0.fsf@localhost> <871pxlhto4.fsf@recursewithless.net> <8734i1q8p1.fsf@localhost> <874j2d8u55.fsf@recursewithless.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31810"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Richard Lawrence Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 05 14:28:36 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUQgF-0008AX-OO for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Jan 2025 14:28:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUQfW-0004R8-6D; Sun, 05 Jan 2025 08:27:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUQfU-0004QS-B2 for emacs-devel@gnu.org; Sun, 05 Jan 2025 08:27:48 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUQfR-0004El-FB for emacs-devel@gnu.org; Sun, 05 Jan 2025 08:27:48 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 42C3B240027 for ; Sun, 5 Jan 2025 14:27:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1736083661; bh=/+yrj6sEnvzAaYvQAgJ27L5dtHZ8HGOJJzXl3MHC84w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=aZW2wV7O4cG2aaHtd1Sv11Q0gtO0sOviTY3wFvFLpOFu8/YTFTgHecT57nN0ROd0U MCML0Gnk2cGExx1+CZywvcJTdu1OSHibDUq0oQqnbnxTwY62e/Xf1+CpniZWf1vDeF lE/Xft2xw6l8vaBgX6QUl1joKDwjOtmXRX89qmNU0VF3U2WaySJXFW1iOzNfvW7qLO HWU+84zFog8QlyCMaJA5xeqAmBi8wAwft3iGq+hjEVlGNQW22v+o7rkJoq5LiuTsnq RQbrfZa6Ki3iPmcIEdn+rDVg9HJL9O/b6oyqRF711sg7jQwvYGBo0dB4c7cpCceAk/ h28IWOoZMIfCg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YQymD6SWSz9rxD; Sun, 5 Jan 2025 14:27:40 +0100 (CET) In-Reply-To: <874j2d8u55.fsf@recursewithless.net> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327721 Archived-At: Richard Lawrence writes: > The reason is that, with the former definition, children will be bound to > `(nil)' in the call to org-element-create, while in the latter it will > be bound to `nil'. The root of the problem is that > > (org-element-create 'foo (list ...)) > (org-element-create 'foo (list ...) nil) > > are not equivalent; in particular > > (org-element-contents (org-element-create 'foo (list ...))) ; => nil > (org-element-contents (org-element-create 'foo (list ...) nil)) ; => (nil) I see. In other words, you want to make (org-element-create 'foo (list ...) children) work when CHILDREN=nil I think I can just add a special case to `org-element-create': when CHILDREN is (nil), ignore it. Does it make sense? -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at