Re: Upstreaming org-element-ast (was: Improving Emacs' iCalendar support)

[Ihor Radchenko <yantar92@posteo.net>]

Richard Lawrence <rwl@recursewithless.net> writes:

> The reason is that, with the former definition, children will be bound to
> `(nil)' in the call to org-element-create, while in the latter it will
> be bound to `nil'. The root of the problem is that
>
> (org-element-create 'foo (list ...))
> (org-element-create 'foo (list ...) nil)
>
> are not equivalent; in particular
>
> (org-element-contents (org-element-create 'foo (list ...))) ; => nil
> (org-element-contents (org-element-create 'foo (list ...) nil)) ; => (nil)

I see.
In other words, you want to make
(org-element-create 'foo (list ...) children)
work when CHILDREN=nil

I think I can just add a special case to `org-element-create':
when CHILDREN is (nil), ignore it.

Does it make sense?

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>