From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: Recent isearch changes in eshell Date: Tue, 17 Dec 2024 21:25:18 -0800 Message-ID: <87cfd588-a2e0-dd39-9fde-3c9350260e56@gmail.com> References: <874j339162.fsf@yandex.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32786"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andreas Schwab , Colin Baxter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 18 06:26:14 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNmZZ-0008NH-Qg for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Dec 2024 06:26:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNmYm-0006KM-6l; Wed, 18 Dec 2024 00:25:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNmYk-0006Js-Dp for emacs-devel@gnu.org; Wed, 18 Dec 2024 00:25:22 -0500 Original-Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNmYj-00071m-0O for emacs-devel@gnu.org; Wed, 18 Dec 2024 00:25:22 -0500 Original-Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-218c8aca5f1so19356715ad.0 for ; Tue, 17 Dec 2024 21:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734499519; x=1735104319; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=UcXOZrBW1MkPGM9xtGn5XDSQPxM9Cjd4m0KMNIrt4ic=; b=F9zedu1EE+J27svkU8I4nK2IyRf9+4PdrlTq6Ao9dIZC1jVYgVGmCbrrWNcVbR82oy KrBib8kzvuB2Ty76vRN47fpfvZx1u8CYngdVtVTaTYzmlB14O9UsmbDWX/IfYqGnekO7 9obP60WLPqRkNPECAlxsZtsefXTeuqe/bFFMwdod5Y25e/GGp63vJe83FZWZLdcZsq90 SdlPSubqd2eg8ffqXB5zOfse6RH2CLFPui7Aixh1VxKkBzNB46r2oJv6qg13c4hKoxE+ dodFwA3pMqQqDiHCG50hNHq0VD+P2xKVqO7Q6Y2q4GhR/q2ekfxrFsN9mICWLp+QM6CB YxKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734499519; x=1735104319; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UcXOZrBW1MkPGM9xtGn5XDSQPxM9Cjd4m0KMNIrt4ic=; b=Swo/g6LJnLzUD6mYKke0HB0lJxN6T97XESocTTkoO7dj2I/17CwpQmzpxjCL7bKQFQ 8zje+XDQCtKF61nijDKYSXGAaJ9HokcMihG7VN5jxHdLlLImbHPW9puta79wjkn18EDh VRYoz+Vm9lcYtclAVU3xr54fnR3g0RmhRv8HnLBwSvOUSw39/TqpzQyex0fAHhQPPSqZ lKk535fs9EMH8BaQjulU9Pj8GBIBRt3HJpyDoR9My1WIbV/bcTkbqqNZcCUThD1PJoV0 ea8Ueb8VC+ojVdj/VbK3C5UfbyOL2sB9L215kxdEg/HUURYVI8JKqp3K6nwCE9GIUSbz Q1cg== X-Gm-Message-State: AOJu0YxmX5Llkoy7MuyJEHQNXWyy35cFbUYDb3CU/IrVyweTySbYQXeB hAX2Hh4wpBjptLCD/lY1k54CkyWOEaGXAxgBAtnghDM86aK8fC1Tac68Mg== X-Gm-Gg: ASbGnctBTAPlx7hCHLocvNSlvwHuUXT2cGRKZXXum04Xowo/d6+onGxEl1f/LtPgws6 G9PlYXeREqUEbhlFRmEWeS0zvspHi4DUp0qtz9sL5VlWSSYr0bC2WhHXzwbuXbB34Hi3c8sUa6F yuvqSpEtolQ9FTm4UsfymmcUAVhsD/q9xWYo8SNfVVQHHSWKTgdYGsrj/cKgq7BITKXx/MF+KOs Zi/87cbUAPBcAzeapjVQeMidK7gXE3E51hJe6G9N3Mu1arzKrLQka1DCWP+qdVBJPqo2cQJv4o7 rCFwa/YSS5c7ROxZ60zcjpexIfUDwda66w== X-Google-Smtp-Source: AGHT+IESXPV1lUV8SmnNs9c3kqB10sKRs+ymfpWdSevMascu7FsTxSOz1Y4AbqpjkYshO1egV/wMmA== X-Received: by 2002:a17:903:191:b0:216:393b:23e9 with SMTP id d9443c01a7336-218d7103a9fmr18620105ad.20.1734499519017; Tue, 17 Dec 2024 21:25:19 -0800 (PST) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-218a1e72870sm67868735ad.279.2024.12.17.21.25.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2024 21:25:18 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326627 Archived-At: On 12/16/2024 6:25 AM, Andreas Schwab wrote: > On Dez 16 2024, Colin Baxter wrote: > >> Recently, isearch in eshell was changed. According to NEWS, the >> following will revert the changes: >> >> (keymap-set eshell-hist-mode-map "M-r" >> #'eshell-previous-matching-input) >> (keymap-set eshell-hist-mode-map "M-s" >> #'eshell-next-matching-input) >> >> It seems that the above will only work if they are evaluated after >> calling eshell, otherwise they give "void variable eshell-hist-mode-map" >> error. > > (with-eval-after-load 'em-hist ...) Thanks (and thanks for Colin for reporting this). Now fixed in 43fcda0c8ea.