From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: John Paul Wallington Newsgroups: gmane.emacs.devel Subject: Re: `eshell-under-cygwin-p' etc. inappropriate? Date: 07 Aug 2002 06:06:12 +0100 Sender: emacs-devel-admin@gnu.org Message-ID: <87bs8f8dh7.fsf@bundalo.shootybangbang.com> References: <87bs8fn34y.fsf@alice.dynodns.net> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1028696490 8206 127.0.0.1 (7 Aug 2002 05:01:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 7 Aug 2002 05:01:30 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17cIwr-00028F-00 for ; Wed, 07 Aug 2002 07:01:29 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17cJII-000400-00 for ; Wed, 07 Aug 2002 07:23:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17cIxR-000774-00; Wed, 07 Aug 2002 01:02:05 -0400 Original-Received: from main.gmane.org ([80.91.224.249]) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17cIx5-00076S-00 for ; Wed, 07 Aug 2002 01:01:43 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 17cIwF-00025c-00 for ; Wed, 07 Aug 2002 07:00:51 +0200 Original-To: emacs-devel@gnu.org X-Injected-Via-Gmane: http://gmane.org/ Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 17cIwA-00025M-00 for ; Wed, 07 Aug 2002 07:00:46 +0200 Original-Path: 127.0.0.1!nobody Original-Newsgroups: gmane.emacs.devel Original-Lines: 35 Original-NNTP-Posting-Host: modem-1048.chansey.dialup.pol.co.uk Original-X-Trace: main.gmane.org 1028696446 8017 217.135.68.24 (7 Aug 2002 05:00:46 GMT) Original-X-Complaints-To: usenet@main.gmane.org Original-NNTP-Posting-Date: Wed, 7 Aug 2002 05:00:46 +0000 (UTC) User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6322 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6322 John Wiegley wrote: > >>>>> On Tue Aug 6, John writes: > > > This was a patch I suggested for the eshell XEmacs package. I'm not > > certain it is appropriate for XEmacs, but I don't think it should > > have been installed in Emacs. I thought it had been rejected, > > rightly. > > That's odd; I thought we had agreed to check them in. Why should the > XEmacs version diverge from Emacs? Emacs runs under cygwin also. XEmacs can be built both for Windows and for Cygwin, and the behavior of the builds is different. Emacs cannot be built for Cygwin, I think. You are right that eshell shouldn't diverge; I hadn't thought about that in April. > > Furthermore, `eshell-under-cygwin-p' is a misleading name: it should > > probably be `eshell-under-xemacs-cygwin-p' or similar. > > Why? Because with Emacs running on/under Cygwin it will return nil. It really only tests whether you have the XEmacs Cygwin build. > > I don't understand why these changes were installed now, four months > > after they were suggested. > > If you want them removed, I will remove them. It's been four months > because that's how long it's taken me to get back to my Emacs work. Maybe `eshell-under-cygwin-p' should be called something else? -- John Paul Wallington