From: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Starnge comment in Custom Theme code.
Date: Sat, 24 Dec 2005 12:21:47 -0500 [thread overview]
Message-ID: <87bqz6h0lw.fsf@stupidchicken.com> (raw)
In-Reply-To: <200512241630.jBOGU6H09878@raven.dms.auburn.edu> (Luc Teirlinck's message of "Sat, 24 Dec 2005 10:30:06 -0600 (CST)")
Luc Teirlinck <teirllm@dms.auburn.edu> writes:
> What does the following comment starting on line 679 of custom.el
> mean? I believe that we decided that a theme should never override a
> value defined with setq or otherwise set outside Custom. So the user
> value does not have to "come back", it never goes away.
>
> ;; Add a new setting.
> ;; If the user changed the value outside of Customize, we
> ;; first save the current value to a fake theme, `standard'.
> ;; This ensures that the user-set value comes back if the
> ;; theme is later disabled.
I don't know where "we" decided that, but I wrote that part at
Richard's request.
> What does the code that follows the comment do? Nobody will ever find
> bugs in the Themes code by using it, because nobody is using it. So
> the only way to find bugs is to read the source code and see what it
> does. Did anybody ever do that? I tried and concluded that it was
> just an incoherent bunch of nonsense, that was not worth trying to fix.
I don't know how many people are using the Themes code, but it is
pretty understandable to me (and I wasn't even the original author).
I don't know what your belly-aching is supposed to accomplish; if
you're suggesting to rewrite the Custom Themes code, it's rather too
late in the release process for that.
next prev parent reply other threads:[~2005-12-24 17:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-24 16:30 Starnge comment in Custom Theme code Luc Teirlinck
2005-12-24 17:21 ` Chong Yidong [this message]
2005-12-24 18:02 ` Luc Teirlinck
2005-12-24 18:35 ` Chong Yidong
2005-12-24 18:39 ` Luc Teirlinck
2005-12-24 18:42 ` Chong Yidong
2005-12-24 18:53 ` Luc Teirlinck
2005-12-24 18:49 ` Luc Teirlinck
2005-12-25 2:32 ` Luc Teirlinck
2005-12-26 2:20 ` Richard M. Stallman
2005-12-26 4:21 ` Luc Teirlinck
2005-12-26 21:57 ` Richard M. Stallman
2005-12-26 18:05 ` Luc Teirlinck
2005-12-24 18:30 ` Luc Teirlinck
2005-12-24 19:04 ` Luc Teirlinck
2005-12-24 20:58 ` Luc Teirlinck
2005-12-25 1:45 ` Luc Teirlinck
2005-12-26 2:20 ` Richard M. Stallman
2005-12-26 3:29 ` Luc Teirlinck
2005-12-27 4:55 ` Richard M. Stallman
2005-12-26 4:26 ` Luc Teirlinck
2005-12-26 18:43 ` Richard M. Stallman
2005-12-27 2:13 ` Luc Teirlinck
2005-12-25 2:52 ` Richard M. Stallman
2005-12-25 3:03 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bqz6h0lw.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).