From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: use of (defvar <foo>)
Date: Sun, 09 Apr 2006 20:29:53 -0400 [thread overview]
Message-ID: <87bqvas2ls.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <rzqr746ua2g.fsf@loveshack.ukfsn.org> (Dave Love's message of "Sun, 09 Apr 2006 14:56:23 +0100")
>> From the future's point of view (Emacs-22 and up), placing such defvars
>> inside eval-when-compile is a bad practice (in the future it may even fail
>> to work since there's nothing that guarantees that the content of
>> eval-when-compile is actually compiled rather than just eval'd).
> Huh? You don't want it compiled -- that's the point.
By "compiled" I only mean that it goes through the byte-compiler (before
being eval'd). Not that the resulting byte-code is written in the
output file.
If the content of eval-when-compile were not compiled, then
(eval-when-compile (defvar foo)) would be 100% equivalent to a nop.
It's only because it's both compiled&eval'd that the byte-compiler notices
the defvar and thus silences warnings about subsequent uses of
this variable.
> You're actually considering changing what eval-when-compile does and
> breaking more existing code??
Compiling the content of eval-when-compile before eval'ing doesn't
remove/hide any bug AFAIK, quite the opposite.
Stefan
next prev parent reply other threads:[~2006-04-10 0:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <rzqfykqo6cu.fsf@loveshack.ukfsn.org>
[not found] ` <v9fykq8oiv.fsf@marauder.physik.uni-ulm.de>
[not found] ` <rzqek09mwvl.fsf@loveshack.ukfsn.org>
2006-04-07 19:07 ` use of (defvar <foo>) Reiner Steib
2006-04-07 20:45 ` Stefan Monnier
2006-04-07 23:48 ` Bill Wohler
2006-04-09 13:56 ` Dave Love
2006-04-09 14:02 ` David Kastrup
2006-04-11 16:45 ` Dave Love
2006-04-10 0:29 ` Stefan Monnier [this message]
2006-04-11 17:06 ` Dave Love
2006-04-11 17:31 ` David Kastrup
2006-04-13 16:44 ` Dave Love
2006-04-11 18:42 ` Stefan Monnier
2006-04-13 16:51 ` Dave Love
2006-04-08 16:17 ` Richard Stallman
2006-04-09 14:03 ` Dave Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bqvas2ls.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).