From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Diane Murray Newsgroups: gmane.emacs.devel Subject: Respect `url-show-status' for all types of status messages Date: Thu, 23 Nov 2006 02:11:32 +0100 Message-ID: <87bqmzufuj.fsf@x3y2z1.net> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1164244248 11188 80.91.229.2 (23 Nov 2006 01:10:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 23 Nov 2006 01:10:48 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 23 02:10:47 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gn36z-0006P5-V8 for ged-emacs-devel@m.gmane.org; Thu, 23 Nov 2006 02:10:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gn36z-0003mq-Ej for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2006 20:10:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gn36n-0003mb-AA for emacs-devel@gnu.org; Wed, 22 Nov 2006 20:10:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gn36l-0003m5-55 for emacs-devel@gnu.org; Wed, 22 Nov 2006 20:10:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gn36l-0003m2-0k for emacs-devel@gnu.org; Wed, 22 Nov 2006 20:10:31 -0500 Original-Received: from [194.25.134.20] (helo=mailout08.sul.t-online.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gn36k-0007Co-PG for emacs-devel@gnu.org; Wed, 22 Nov 2006 20:10:30 -0500 Original-Received: from fwd28.aul.t-online.de by mailout08.sul.t-online.com with smtp id 1Gn36j-0001gE-00; Thu, 23 Nov 2006 02:10:29 +0100 Original-Received: from spargel (SsGF36Zv8ewlurgerd80xRaO49E3TG0x2o4nhcN45TXqMXxOeLf-8X@[84.189.214.147]) by fwd28.sul.t-online.de with esmtp id 1Gn36c-1DmLdA0; Thu, 23 Nov 2006 02:10:22 +0100 Original-To: emacs-devel@gnu.org X-ID: SsGF36Zv8ewlurgerd80xRaO49E3TG0x2o4nhcN45TXqMXxOeLf-8X@t-dialin.net X-TOI-MSGID: 58bcdc80-7e9b-4e5d-ba18-9f7100cd1c12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62706 Archived-At: Even though `url-show-status' is non-nil, URL displays the percentage of total bytes transferred as messages. This can block the minibuffer, especially when the file to retrieve is large or the connection is slow. Since the documentation for the variable states "Whether to show a running total of bytes transferred", I assume this is a bug and have provided a patch. 2006-11-23 Diane Murray * url-http.el (url-http-content-length-after-change-function): Use `url-lazy-message'. * url-util.el (url-display-percentage): Only show a message if `url-show-status' is non-nil. Index: url-http.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/url/url-http.el,v retrieving revision 1.43 diff -u -r1.43 url-http.el --- url-http.el 15 Nov 2006 23:29:43 -0000 1.43 +++ url-http.el 23 Nov 2006 00:43:30 -0000 @@ -819,7 +819,7 @@ (progn ;; Found the end of the document! Wheee! (url-display-percentage nil nil) - (message "Reading... done.") + (url-lazy-message "Reading... done.") (if (url-http-parse-headers) (url-http-activate-callback))))) Index: url-util.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/url/url-util.el,v retrieving revision 1.14 diff -u -r1.14 url-util.el --- url-util.el 31 Jul 2006 21:36:42 -0000 1.14 +++ url-util.el 23 Nov 2006 00:47:33 -0000 @@ -244,12 +244,13 @@ ;;;###autoload (defun url-display-percentage (fmt perc &rest args) - (if (null fmt) - (if (fboundp 'clear-progress-display) - (clear-progress-display)) - (if (and (fboundp 'progress-display) perc) - (apply 'progress-display fmt perc args) - (apply 'message fmt args)))) + (when url-show-status + (if (null fmt) + (if (fboundp 'clear-progress-display) + (clear-progress-display)) + (if (and (fboundp 'progress-display) perc) + (apply 'progress-display fmt perc args) + (apply 'message fmt args))))) ;;;###autoload (defun url-percentage (x y)