unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: rms@gnu.org
Cc: acm@muc.de, markus.triska@gmx.at, emacs-devel@gnu.org
Subject: Re: Nonsensical byte compiler warning.
Date: Thu, 05 Apr 2007 14:01:07 -0400	[thread overview]
Message-ID: <87bqi2bt0c.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1HZLpt-0008VG-PZ@fencepost.gnu.org> (Richard Stallman's message of "Thu\, 05 Apr 2007 02\:52\:45 -0400")

Richard Stallman <rms@gnu.org> writes:

>     > The line number is that of the first form of the function the
>     > questionable code is in. That makes sense, since the problem is in
>     > that function. It is *not* the call of char-before that's bogus. It's
>     > that its return value isn't used in the caller, c-end-of-defun. Any
>     > line of that function could contain the oversight. What line number
>     > would in your view make more sense to report?
>
>     The line number of the call to char-before, of course.  The line
>     number of the whole enclosing function is plain useless.
>
> I agree.
>
> I don't know how hard it will be to make this useful line number
> appear, but someone should investigate and _try_ to fix it.
> Let's have no more of the argument that this is not a bug!

After looking at this, I don't think it is practical to fix the line
number.  However, I changed the warning to print the entire form,
which should make it much easier to figure out where the problematic
code is (in this case, even if the form has been changed by previous
optimizations, it shouldn't be too difficult to figure out what the
original form was).

  parent reply	other threads:[~2007-04-05 18:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01 17:14 Nonsensical byte compiler warning David Kastrup
2007-04-01 18:10 ` Chong Yidong
2007-04-01 20:57   ` Alan Mackenzie
2007-04-02 12:29   ` Richard Stallman
2007-04-04  4:48     ` Markus Triska
2007-04-04  6:15       ` David Kastrup
2007-04-04  8:19         ` Markus Triska
2007-04-04  8:46           ` David Kastrup
2007-04-04  9:50             ` Markus Triska
2007-04-04 10:17               ` David Kastrup
2007-04-04 12:35                 ` Markus Triska
2007-04-04 18:25                 ` Markus Triska
2007-04-04 22:13                   ` David Kastrup
2007-04-05  6:52             ` Richard Stallman
2007-04-05  7:55               ` Markus Triska
2007-04-06 12:56                 ` Richard Stallman
2007-04-06 15:11                   ` Chong Yidong
2007-04-08 20:47                   ` Markus Triska
2007-04-09 15:42                     ` Richard Stallman
2007-04-10  3:53                       ` Glenn Morris
2007-04-10 17:27                         ` Markus Triska
2007-04-11  4:00                           ` Glenn Morris
2007-04-05 18:01               ` Chong Yidong [this message]
2007-04-04 20:08           ` Alan Mackenzie
2007-04-04 21:45             ` Markus Triska
2007-04-04 22:11               ` Chong Yidong
2007-04-05  5:44                 ` Markus Triska
2007-04-08  1:21             ` Kim F. Storm
2007-04-08 11:27               ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bqi2bt0c.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=markus.triska@gmx.at \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).