From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel Subject: Re: State of VC? Date: Thu, 24 Jan 2008 09:58:53 +0100 Message-ID: <87bq7bd2gi.fsf@ambire.localdomain> References: <20080122164306.3B33C83045C@snark.thyrsus.com> <200801222207.m0MM7rlR014153@sallyv1.ics.uci.edu> <200801240707.m0O77KcX018757@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201182458 12942 80.91.229.12 (24 Jan 2008 13:47:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jan 2008 13:47:38 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 24 14:47:58 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JI2Qv-0001S9-Pp for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 14:47:58 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JI2QV-0005eT-ET for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 08:47:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JI2QR-0005cx-6B for emacs-devel@gnu.org; Thu, 24 Jan 2008 08:47:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JI2QP-0005cD-OQ for emacs-devel@gnu.org; Thu, 24 Jan 2008 08:47:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JI2QP-0005cA-F8 for emacs-devel@gnu.org; Thu, 24 Jan 2008 08:47:25 -0500 Original-Received: from ppp-60-36.21-151.libero.it ([151.21.36.60] helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JI2QP-0002JB-2i for emacs-devel@gnu.org; Thu, 24 Jan 2008 08:47:25 -0500 Original-Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1JHxvB-00027M-1L for emacs-devel@gnu.org; Thu, 24 Jan 2008 09:58:53 +0100 In-Reply-To: <200801240707.m0O77KcX018757@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 23 Jan 2008 23:07:19 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-Greylist: delayed 1281 seconds by postgrey-1.27 at monty-python; Thu, 24 Jan 2008 08:46:56 EST X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87436 Archived-At: () Dan Nicolaescu () Wed, 23 Jan 2008 23:07:19 -0800 The problem here is indeed in vc-diff-sentinel. It calls (shrink-window-if-larger-than-buffer) which does this: (when (null window) (setq window (selected-window))) So it will look at (selected-window), so it will shrink the wrong window... Not sure what the best solution is here. i just installed a fix. btw, in the cvs log, i used the format: ONE-LINE-DESCRIPTION. (FUNC): CHANGE. (OTHER-FUNC): CHANGE. as opposed to the format w/o `ONE-LINE-DESCRIPTION.\n\n' (which is what went into ChangeLog). any objections? thi