unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [mouse-1 in Customize should respect mouse-1-click-follows-link]
Date: Wed, 12 Mar 2008 11:02:55 +0000	[thread overview]
Message-ID: <87bq5k9pcw.fsf@bzg.ath.cx> (raw)
In-Reply-To: <004a01c8826a$2566fdb0$0600a8c0@us.oracle.com> (Drew Adams's message of "Sun, 9 Mar 2008 20:49:37 -0800")

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

"Drew Adams" <drew.adams@oracle.com> writes:

> These are links. They should be controlled by
> `mouse-1-click-follows-link'.

They behave like links but they are really widget buttons.
I doubt there is a simple fix for this.

,----[ `C-u C-x =' on such a "link" ]
| This is an active area of a documentation-link (widget)Top.
| 
| There are 2 overlays here:
|  From 3145 to 3885
|   evaporate            t
|   face                 custom-documentation
|   widget-doc           documentation-string (widget)Top
|  From 3372 to 3384
|   button               documentation-link (widget)Top
|   evaporate            t
|   face                 custom-documentation
|   follow-link          mouse-face
|   help-echo            "Describe this symbol"
|   keymap               nil
|   mouse-face           (highlight)
|   pointer              hand
`----

Anyway, the `follow-link' property was set to "^m".
The following patch corrects this.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: wid-edit.el.patch --]
[-- Type: text/x-diff, Size: 510 bytes --]

Index: wid-edit.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/wid-edit.el,v
retrieving revision 1.188
diff -u -r1.188 wid-edit.el
--- wid-edit.el	9 Feb 2008 22:48:05 -0000	1.188
+++ wid-edit.el	12 Mar 2008 10:57:02 -0000
@@ -1773,7 +1773,7 @@
   "An embedded link."
   :button-prefix 'widget-link-prefix
   :button-suffix 'widget-link-suffix
-  :follow-link "\C-m"
+  :follow-link 'mouse-face
   :help-echo "Follow the link."
   :format "%[%t%]")
 

[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


-- 
Bastien

  reply	other threads:[~2008-03-12 11:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 22:09 [mouse-1 in Customize should respect mouse-1-click-follows-link] Richard Stallman
2008-03-10  4:49 ` Drew Adams
2008-03-12 11:02   ` Bastien [this message]
2008-03-14 10:16     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bq5k9pcw.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).